Differential D8613

Properly show/hide preview dialog
AbandonedPublic
Actions

Authored by wbauer on Nov 2 2017, 8:23 AM.

Details

Reviewers
ltoscano
chehrlic
Group Reviewers
KDE Games
Summary

The visiblity of the preview dialog was not synced with the preview action in the main window. Also the preview image was not created when then same puzzle was opened after going back to the overview.
Don't leak PuzzleComponent in GamePlay::loadPreview()

This is a backport of commit 851870fbfae1 to the kdelibs4 based 17.08 branch.

Test Plan
  • compiles
  • preview menu option is now properly checked/unchecked when opening a puzzle (and state is remembered)
  • preview picture is correctly loaded/displayed if enabled

Diff Detail

Repository
R423 Palapeli
Lint
Lint Skipped
Unit
Unit Tests Skipped
wbauer created this revision.Nov 2 2017, 8:23 AM
wbauer updated this revision to Diff 21960.Nov 6 2017, 12:44 PM
wbauer edited the test plan for this revision. (Show Details)

Remove unrelated change

wbauer abandoned this revision.Nov 8 2017, 8:47 AM

17.08.3 (the last kdelibs4 based release) has been tagged meanwhile, so it's too late for this now...

ltoscano added a comment.Nov 8 2017, 8:53 AM

Sorry, I was on vacation and I missed it. In general, for last minute fixes to KDE Applications, the best way is an email to release-team@kde.org

Revision Contents
Changeset List

PathPackages
Msrc/engine/gameplay.cpp (12 lines)
Msrc/window/mainwindow.cpp (2 lines)

Diff 21960

View Options

src/engine/gameplay.cpp

Loading...
View Options

src/window/mainwindow.cpp

Loading...