Differential D8605

Merge multithreaded version of Pixel Brush into master
ClosedPublic
Actions

Authored by dkazakov on Nov 1 2017, 9:15 PM.

Details

Reviewers

rempt

Group Reviewers

Krita

Commits

R37:89f7b9e2a971: Merge remote-tracking branch 'origin/kazakov/multithreaded-brushes'

Summary

This patch represents the contents of 'kazakov/multithreaded-brushes' branch.

Now Pixel Brush engine is fully multithreaded. The number of used threads is controlled by the Threads Limit option in "Performance" tab of the preferences.

Test Plan

All the features of Pixel Brush should work as usual, but several times faster :)

Diff Detail

Repository

R37 Krita

Branch

kazakov/multithreaded-brushes

Lint

No Linters Available

Unit

No Unit Test Coverage

dkazakov created this revision.Nov 1 2017, 9:15 PM

dkazakov edited the summary of this revision. (Show Details)Nov 1 2017, 9:17 PM

dkazakov edited the test plan for this revision. (Show Details)

dkazakov added reviewers: Krita, rempt.

dkazakov added a project: Krita.

Okay, most of this goes above my head, but I found a typo that might need to be fixed.

I do have a vague comprehension now of how the new system works, it'll be interesting to get the hsv patch for colored brush masks weaved in anew.

libs/pigment/KoColor.cpp
40	This is a bit silly, but maybe this typo could be fixed before merge? Then we won't have to force people to build all of krita again when someone fixes the typo later :p
plugins/paintops/defaultpaintops/brush/kis_brushop.cpp
265	This and line 257... their results seem virtually the same. Any reason why you check them seperately?

I mostly just spent some time and tested painting using different brushes, instant preview, and looked at the live preview. Everything seems to work really well!

Great job! This is really exciting.

Patches of this size aren't reviewable... So it'll testing in practice.

Bugs and notes are to be collected here:

https://phabricator.kde.org/T7309

This revision is now accepted and ready to land.Nov 2 2017, 8:05 AM

Hi, @woltherav!

Thank you for the notes! I have fixed them locally and will push directly into the branch :)

libs/pigment/KoColor.cpp
40	Fixed! Thank you!
plugins/paintops/defaultpaintops/brush/kis_brushop.cpp
265	Yes, in case we have both types of mirrors, we should copy the dab 3 times :) Just note, that there is no "else" branch. It just adds one more mirroring step in case the both mirrors are active. It allows us to avoid one copying. Anyway, I will add a comment into the code giving details about that.

There, uh, was a minor bug with the brush preview that I went and fixed: https://phabricator.kde.org/R37:06ea68a92974976c96a6f4560e47af3caadba654

Not sure what exactly caused it, but we might be mindful that the new kocolor default might cause this in other places.

Closed by 89f7b9e2a971

Large Diff

This large diff affects 201 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

			Path
M			libs/brush/kis_auto_brush.cpp (23 lines)
M			libs/brush/kis_brush.h (33 lines)
M			libs/brush/kis_brush.cpp (27 lines)
M			libs/brush/kis_brushes_pipe.h (17 lines)
M			libs/brush/kis_dab_shape.h (8 lines)
M			libs/brush/kis_gbr_brush.h (5 lines)
M			libs/brush/kis_gbr_brush.cpp (1 line)
M			libs/brush/kis_imagepipe_brush.h (1 line)
M			libs/brush/kis_imagepipe_brush.cpp (17 lines)
M			libs/brush/kis_text_brush.h (1 line)
M			libs/brush/kis_text_brush.cpp (34 lines)
M			libs/brush/tests/kis_gbr_brush_test.h (2 lines)
M			libs/brush/tests/kis_gbr_brush_test.cpp (64 lines)
M			libs/brush/tests/kis_imagepipe_brush_test.cpp (5 lines)
M			libs/global/CMakeLists.txt (5 lines)
A	M		libs/global/KisRollingMeanAccumulatorWrapper.h (60 lines)
A	M		libs/global/KisRollingMeanAccumulatorWrapper.cpp (61 lines)
P			libs/global/KisSharedRunnable.h (31 lines) Copied from libs/ui/opengl/kis_opengl_canvas_debugger.h
P			libs/global/KisSharedRunnable.cpp (25 lines) Copied from libs/image/kis_projection_updates_filter.cpp
A	M		libs/global/KisSharedThreadPoolAdapter.h (53 lines)
A	M		libs/global/KisSharedThreadPoolAdapter.cpp (98 lines)
A	M		libs/global/tests/CMakeLists.txt (8 lines)
P			libs/global/tests/KisSharedThreadPoolAdapterTest.h (28 lines) Copied from libs/image/kis_projection_updates_filter.cpp
A	M		libs/global/tests/KisSharedThreadPoolAdapterTest.cpp (72 lines)
M			libs/image/CMakeLists.txt (8 lines)
P			libs/image/KisFakeRunnableStrokeJobsExecutor.h (23 lines) Copied from libs/image/kis_projection_updates_filter.cpp
P			libs/image/KisFakeRunnableStrokeJobsExecutor.cpp (26 lines) Copied from libs/image/kis_projection_updates_filter.cpp
P			libs/image/KisRenderedDab.h (47 lines) Copied from libs/ui/opengl/kis_opengl_canvas_debugger.h
A	M		libs/image/KisRunnableBasedStrokeStrategy.h (44 lines)
A	M		libs/image/KisRunnableBasedStrokeStrategy.cpp (79 lines)
A	M		libs/image/KisRunnableStrokeJobData.h (45 lines)
A	M		libs/image/KisRunnableStrokeJobData.cpp (48 lines)
P			libs/image/KisRunnableStrokeJobsInterface.h (29 lines) Copied from libs/image/kis_projection_updates_filter.cpp
P			libs/image/KisRunnableStrokeJobsInterface.cpp (19 lines) Copied from libs/image/kis_projection_updates_filter.cpp
P			libs/image/KisStrokesQueueMutatedJobInterface.h (26 lines) Copied from libs/image/kis_projection_updates_filter.cpp
P			libs/image/KisStrokesQueueMutatedJobInterface.cpp (18 lines) Copied from libs/image/kis_projection_updates_filter.cpp
P			libs/image/KisUpdaterContextSnapshotEx.h (30 lines) Copied from libs/image/kis_projection_updates_filter.cpp
P			libs/image/brushengine/KisStrokeSpeedMeasurer.h (32 lines) Copied from libs/ui/opengl/kis_opengl_canvas_debugger.h
A	M		libs/image/brushengine/KisStrokeSpeedMeasurer.cpp (179 lines)
M			libs/image/brushengine/kis_paint_information.h (16 lines)
M			libs/image/brushengine/kis_paint_information.cc (109 lines)
M			libs/image/brushengine/kis_paintop.h (10 lines)
M			libs/image/brushengine/kis_paintop.cc (6 lines)
M			libs/image/brushengine/kis_paintop_settings.h (6 lines)
M			libs/image/brushengine/kis_paintop_settings.cpp (5 lines)
M			libs/image/brushengine/kis_paintop_utils.h (57 lines)
A	M		libs/image/brushengine/kis_paintop_utils.cpp (117 lines)
M			libs/image/generator/kis_generator_layer.h (2 lines)
M			libs/image/generator/kis_generator_layer.cpp (4 lines)
M			libs/image/kis_brush_mask_applicators.h (24 lines)
M			libs/image/kis_distance_information.h (35 lines)
M			libs/image/kis_distance_information.cpp (119 lines)
M			libs/image/kis_fixed_paint_device.h (17 lines)
M			libs/image/kis_fixed_paint_device.cpp (76 lines)
M			libs/image/kis_image.h (4 lines)
M			libs/image/kis_image.cc (28 lines)
M			libs/image/kis_image_animation_interface.h (2 lines)
M			libs/image/kis_image_animation_interface.cpp (28 lines)
M			libs/image/kis_node.h (4 lines)
M			libs/image/kis_node.cpp (10 lines)
M			libs/image/kis_node_graph_listener.h (2 lines)
M			libs/image/kis_node_graph_listener.cpp (2 lines)
M			libs/image/kis_painter.h (61 lines)
M			libs/image/kis_painter.cc (139 lines)
A	M		libs/image/kis_painter_blt_multi_fixed.cpp (206 lines)
A	M		libs/image/kis_painter_p.h (105 lines)
M			libs/image/kis_projection_updates_filter.h (4 lines)
P			libs/image/kis_projection_updates_filter.cpp (4 lines) Copied to multiple locations: libs/global/KisSharedRunnable.cpp libs/global/tests/KisSharedThreadPoolAdapterTest.h libs/image/KisFakeRunnableStrokeJobsExecutor.cpp libs/image/KisFakeRunnableStrokeJobsExecutor.h libs/image/KisRunnableStrokeJobsInterface.cpp libs/image/KisRunnableStrokeJobsInterface.h libs/image/KisStrokesQueueMutatedJobInterface.cpp libs/image/KisStrokesQueueMutatedJobInterface.h libs/image/KisUpdaterContextSnapshotEx.h libs/ui/tests/FreehandStrokeBenchmark.h plugins/paintops/defaultpaintops/brush/KisBrushOpSettings.cpp plugins/paintops/defaultpaintops/brush/KisBrushOpSettings.h plugins/paintops/defaultpaintops/brush/tests/KisDabRenderingQueueTest.h
M			libs/image/kis_simple_update_queue.h (5 lines)
M			libs/image/kis_simple_update_queue.cpp (68 lines)
M			libs/image/kis_stroke.h (10 lines)
M			libs/image/kis_stroke.cpp (51 lines)
M			libs/image/kis_stroke_job.h (16 lines)
M			libs/image/kis_stroke_job_strategy.h (7 lines)
M			libs/image/kis_stroke_strategy.h (74 lines)
M			libs/image/kis_stroke_strategy.cpp (48 lines)
M			libs/image/kis_strokes_queue.h (15 lines)
M			libs/image/kis_strokes_queue.cpp (107 lines)
M			libs/image/kis_suspend_projection_updates_stroke_strategy.cpp (14 lines)
M			libs/image/kis_update_job_item.h (83 lines)
M			libs/image/kis_update_scheduler.h (3 lines)
M			libs/image/kis_update_scheduler.cpp (19 lines)
M			libs/image/kis_updater_context.h (5 lines)
M			libs/image/kis_updater_context.cpp (59 lines)
M			libs/image/krita_utils.h (4 lines)
M			libs/image/krita_utils.cpp (30 lines)
A	M	(img)	libs/image/tests/data/kispainter_test/massive_bitblt_full_update_3.png
A	M	(img)	libs/image/tests/data/kispainter_test/massive_bitblt_full_update_6.png
A	M	(img)	libs/image/tests/data/kispainter_test/massive_bitblt_full_update_6_sel.png
A	M	(img)	libs/image/tests/data/kispainter_test/massive_bitblt_full_update_6_varyop.png
A	M	(img)	libs/image/tests/data/kispainter_test/massive_bitblt_partial_update_3.png
A	M	(img)	libs/image/tests/data/kispainter_test/massive_bitblt_partial_update_6.png
A	M	(img)	libs/image/tests/data/kispainter_test/massive_bitblt_partial_update_6_sel.png
A	M	(img)	libs/image/tests/data/kispainter_test/massive_bitblt_partial_update_6_varyop.png
M			libs/image/tests/kis_distance_information_test.cpp (12 lines)
M			libs/image/tests/kis_painter_test.h (10 lines)
M			libs/image/tests/kis_painter_test.cpp (278 lines)
M			libs/image/tests/kis_strokes_queue_test.h (6 lines)
M			libs/image/tests/kis_strokes_queue_test.cpp (191 lines)
M			libs/image/tests/scheduler_utils.h (64 lines)
M			libs/image/tiles3/kis_tiled_data_manager.cc (8 lines)
M			libs/pigment/KoColor.h (13 lines)
M			libs/pigment/KoColor.cpp (32 lines)
M			libs/pigment/KoCompositeOp.h (4 lines)
M			libs/pigment/KoCompositeOp.cpp (12 lines)
M			libs/ui/CMakeLists.txt (2 lines)
M			libs/ui/KisApplication.cpp (4 lines)
M			libs/ui/KisViewManager.h (2 lines)
M			libs/ui/KisViewManager.cpp (23 lines)
M			libs/ui/canvas/kis_abstract_canvas_widget.h (1 line)
M			libs/ui/canvas/kis_animation_player.cpp (32 lines)
M			libs/ui/canvas/kis_canvas2.h (2 lines)
M			libs/ui/canvas/kis_canvas2.cpp (29 lines)
M			libs/ui/canvas/kis_canvas_updates_compressor.cpp (25 lines)
M			libs/ui/canvas/kis_canvas_widget_base.h (1 line)
M			libs/ui/canvas/kis_canvas_widget_base.cpp (10 lines)
M			libs/ui/dialogs/kis_dlg_preferences.cc (2 lines)
M			libs/ui/forms/wdgperformancesettings.ui (11 lines)
M			libs/ui/kis_config.h (3 lines)
M			libs/ui/kis_config.cc (10 lines)
M			libs/ui/kis_fps_decoration.cpp (49 lines)
M			libs/ui/opengl/kis_opengl_canvas2.h (2 lines)
M			libs/ui/opengl/kis_opengl_canvas2.cpp (5 lines)
P			libs/ui/opengl/kis_opengl_canvas_debugger.h (8 lines) Copied to multiple locations: libs/global/KisSharedRunnable.h libs/image/KisRenderedDab.h libs/image/brushengine/KisStrokeSpeedMeasurer.h libs/ui/tool/strokes/KisStrokeEfficiencyMeasurer.h plugins/paintops/defaultpaintops/brush/KisBrushOpResources.h
M			libs/ui/opengl/kis_opengl_canvas_debugger.cpp (20 lines)
M			libs/ui/tests/CMakeLists.txt (5 lines)
P			libs/ui/tests/FreehandStrokeBenchmark.h (32 lines) Copied from libs/image/kis_projection_updates_filter.cpp
A	M		libs/ui/tests/FreehandStrokeBenchmark.cpp (142 lines)
A	M	(img)	libs/ui/tests/data/3_texture.png
A	M	(img)	libs/ui/tests/data/testing_1000px_auto_deafult.kpp
A	M	(img)	libs/ui/tests/data/testing_1000px_auto_gaussian.kpp
A	M	(img)	libs/ui/tests/data/testing_1000px_auto_soft.kpp
A	M	(img)	libs/ui/tests/data/testing_1000px_stamp_450_rotated.kpp
A	M	(img)	libs/ui/tests/data/testing_200px_colorsmudge_default.kpp
M			libs/ui/tests/freehand_stroke_test.cpp (7 lines)
A	M		libs/ui/tool/KisStrokeSpeedMonitor.h (83 lines)
A	M		libs/ui/tool/KisStrokeSpeedMonitor.cpp (210 lines)
M			libs/ui/tool/kis_figure_painting_tool_helper.cpp (26 lines)
M			libs/ui/tool/kis_resources_snapshot.h (1 line)
M			libs/ui/tool/kis_resources_snapshot.cpp (25 lines)
M			libs/ui/tool/kis_tool_freehand_helper.h (2 lines)
M			libs/ui/tool/kis_tool_freehand_helper.cpp (44 lines)
A	M		libs/ui/tool/strokes/FreehandStrokeRunnableJobDataWithUpdate.h (41 lines)
P			libs/ui/tool/strokes/KisStrokeEfficiencyMeasurer.h (39 lines) Copied from libs/ui/opengl/kis_opengl_canvas_debugger.h
A	M		libs/ui/tool/strokes/KisStrokeEfficiencyMeasurer.cpp (128 lines)
M			libs/ui/tool/strokes/freehand_stroke.h (69 lines)
M			libs/ui/tool/strokes/freehand_stroke.cpp (253 lines)
M			libs/ui/tool/strokes/kis_painter_based_stroke_strategy.h (5 lines)
M			libs/ui/tool/strokes/kis_painter_based_stroke_strategy.cpp (12 lines)
M			libs/ui/widgets/kis_preset_live_preview_view.h (5 lines)
M			libs/ui/widgets/kis_preset_live_preview_view.cpp (77 lines)
M			libs/ui/widgets/kis_scratch_pad.cpp (9 lines)
M			libs/widgetutils/KoResourcePaths.h (5 lines)
M			libs/widgetutils/KoResourcePaths.cpp (4 lines)
M			plugins/color/lcms2engine/LcmsEnginePlugin.cpp (8 lines)
M			plugins/dockers/throttle/Throttle.h (8 lines)
M			plugins/dockers/throttle/Throttle.cpp (25 lines)
M			plugins/paintops/defaultpaintops/CMakeLists.txt (15 lines)
P			plugins/paintops/defaultpaintops/brush/KisBrushOpResources.h (26 lines) Copied from libs/ui/opengl/kis_opengl_canvas_debugger.h
A	M		plugins/paintops/defaultpaintops/brush/KisBrushOpResources.cpp (95 lines)
P			plugins/paintops/defaultpaintops/brush/KisBrushOpSettings.h (23 lines) Copied from libs/image/kis_projection_updates_filter.cpp
P			plugins/paintops/defaultpaintops/brush/KisBrushOpSettings.cpp (17 lines) Copied from libs/image/kis_projection_updates_filter.cpp
A	M		plugins/paintops/defaultpaintops/brush/KisDabRenderingExecutor.h (65 lines)
A	M		plugins/paintops/defaultpaintops/brush/KisDabRenderingExecutor.cpp (94 lines)
A	M		plugins/paintops/defaultpaintops/brush/KisDabRenderingJob.h (91 lines)
A	M		plugins/paintops/defaultpaintops/brush/KisDabRenderingJob.cpp (169 lines)
A	M		plugins/paintops/defaultpaintops/brush/KisDabRenderingQueue.h (79 lines)
A	M		plugins/paintops/defaultpaintops/brush/KisDabRenderingQueue.cpp (459 lines)
A	M		plugins/paintops/defaultpaintops/brush/KisDabRenderingQueueCache.h (53 lines)
A	M		plugins/paintops/defaultpaintops/brush/KisDabRenderingQueueCache.cpp (45 lines)
M			plugins/paintops/defaultpaintops/brush/kis_brushop.h (38 lines)
M			plugins/paintops/defaultpaintops/brush/kis_brushop.cpp (254 lines)
M			plugins/paintops/defaultpaintops/brush/kis_brushop_settings_widget.cpp (4 lines)
M			plugins/paintops/defaultpaintops/brush/tests/CMakeLists.txt (6 lines)
P			plugins/paintops/defaultpaintops/brush/tests/KisDabRenderingQueueTest.h (29 lines) Copied from libs/image/kis_projection_updates_filter.cpp
A	M		plugins/paintops/defaultpaintops/brush/tests/KisDabRenderingQueueTest.cpp (541 lines)
M			plugins/paintops/defaultpaintops/defaultpaintops_plugin.cc (4 lines)
M			plugins/paintops/deform/deform_brush.cpp (7 lines)
M			plugins/paintops/libpaintop/CMakeLists.txt (2 lines)
A	M		plugins/paintops/libpaintop/KisDabCacheUtils.h (122 lines)
A	M		plugins/paintops/libpaintop/KisDabCacheUtils.cpp (118 lines)
M			plugins/paintops/libpaintop/kis_airbrush_option.cpp (6 lines)
M			plugins/paintops/libpaintop/kis_bidirectional_mixing_option.cpp (2 lines)
M			plugins/paintops/libpaintop/kis_brush_based_paintop.h (2 lines)
M			plugins/paintops/libpaintop/kis_dab_cache.h (57 lines)
M			plugins/paintops/libpaintop/kis_dab_cache.cpp (350 lines)
A	M		plugins/paintops/libpaintop/kis_dab_cache_base.h (128 lines)
A	M		plugins/paintops/libpaintop/kis_dab_cache_base.cpp (280 lines)
M			plugins/paintops/libpaintop/kis_pressure_flow_opacity_option.h (1 line)
M			plugins/paintops/libpaintop/kis_pressure_flow_opacity_option.cpp (22 lines)
M			plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_drawing_angle.h (1 line)
M			plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_drawing_angle.cpp (13 lines)
M			plugins/tools/basictools/strokes/move_stroke_strategy.cpp (2 lines)
M			plugins/tools/selectiontools/kis_tool_select_elliptical.cc (1 line)
M			plugins/tools/selectiontools/kis_tool_select_outline.cc (1 line)
M			plugins/tools/selectiontools/kis_tool_select_polygonal.cc (1 line)
M			plugins/tools/tool_transform2/kis_liquify_paint_helper.cpp (2 lines)
A	M		sdk/tests/KisRectsCollisionsTracker.h (67 lines)
M			sdk/tests/stroke_testing_utils.h (3 lines)
M			sdk/tests/stroke_testing_utils.cpp (12 lines)
M			sdk/tests/testutil.h (65 lines)

Commit	Tree	Parents	Author	Summary	Date
46eb9ae70408	6541c31ad643	c3a1ef807b00	Dmitry Kazakov	Fix live preview for the multithreaded brush (Show More…)	Nov 1 2017, 6:31 PM
c3a1ef807b00	f6217ecccc33	50d326b3e246 d2eb0721fbc0	Dmitry Kazakov	Merge remote-tracking branch 'origin/master' into kazakov/multithreaded-brushes (Show More…)	Nov 1 2017, 5:50 PM
50d326b3e246	6c53df8f3ccd	d93da94864a9	Dmitry Kazakov	Add a class for checking correctness of concurrent access to image areas	Nov 1 2017, 4:51 PM
d93da94864a9	efb0330f038d	eeeedd6eb31c	Dmitry Kazakov	Fixes two "lost tiles" problems in the multithreaded brush (Show More…)	Nov 1 2017, 4:48 PM
eeeedd6eb31c	ce8c32d9b630	493e8c27daa5	Dmitry Kazakov	Fix imagepipe brushes to support multithreaded mode	Oct 26 2017, 6:09 PM
493e8c27daa5	113088ebf065	9671b94f9c96	Dmitry Kazakov	Implement a simple benchmark for the threaded brushes	Oct 25 2017, 1:58 PM
9671b94f9c96	cb2be1f04c3f	559862899e64	Dmitry Kazakov	Fix the freehand stroke test by increasing the fuzzyness	Oct 25 2017, 12:03 PM
559862899e64	e0ee9dfe6ef1	7bff11b69601	Dmitry Kazakov	Fix initialization of the resources manager for stroke-based tests	Oct 25 2017, 11:57 AM
7bff11b69601	9fdb37d63ae7	c11fbf6e5a2a	Dmitry Kazakov	Fix config update problem	Oct 20 2017, 3:15 PM
c11fbf6e5a2a	529b6a5d5039	73ee104ce86d	Dmitry Kazakov	Fix KisDabRenderingQueue and its unittest after the refactoring (Show More…)	Oct 20 2017, 3:02 PM
73ee104ce86d	8dd287114430	4461dcaf7814	Dmitry Kazakov	Fix initialization of KoColor to use QGlobalStatic (Show More…)	Oct 20 2017, 3:00 PM
4461dcaf7814	7fefe7434c2c	dbb062fb089f	Dmitry Kazakov	Add more comments	Oct 20 2017, 11:36 AM
dbb062fb089f	24c6127930c9	02461e0852a1	Dmitry Kazakov	Refactor KisDabRenderingQueue to use shared pointers for jobs instead of copying (Show More…)	Oct 20 2017, 11:33 AM
02461e0852a1	18cffd9291a7	e10883e22863	Dmitry Kazakov	Cache 'lastDabJob' value (Show More…)	Oct 19 2017, 10:05 AM
e10883e22863	8f7a42625896	5bec6444fb31	Dmitry Kazakov	Make dab rendering resources not to be shared among the dab jobs (Show More…)	Oct 19 2017, 9:56 AM
5bec6444fb31	ec9254dddaa4	2b5e8e61793e	Dmitry Kazakov	Avoid extra deep-copies of dabs when mirroring is active (Show More…)	Oct 18 2017, 1:05 PM
2b5e8e61793e	1fc24c810ff8	6f4b8aaf146c	Dmitry Kazakov	Use KisRandomSource instead of std::random_device (Show More…)	Oct 18 2017, 11:39 AM
6f4b8aaf146c	e57d6d2b0ede	eaf421ab7e22	Dmitry Kazakov	Fix memory leak in KisAirbrushOption	Oct 18 2017, 11:38 AM
eaf421ab7e22	aa3c1377a1bc	67eea20583cc	Dmitry Kazakov	Fix a crash and a hangup caused by threading issues in KisUpdateJobItem (Show More…)	Oct 18 2017, 11:34 AM
67eea20583cc	fb852c81705f	de6ff1a62ae7	Dmitry Kazakov	Implement showing brush performance log on canvas overlay (Show More…)	Oct 16 2017, 11:47 AM
de6ff1a62ae7	e09580b6873b	b6b7ba3c477b	Dmitry Kazakov	Fix connection of Throttling plugin to real image cores	Oct 14 2017, 6:47 AM
b6b7ba3c477b	5dab61a3dae2	b51d1090f6e0	Dmitry Kazakov	Fix Instant Preview for the threaded version of the brush	Oct 13 2017, 4:14 PM
b51d1090f6e0	de2581cebddb	115a4c3cf50d	Dmitry Kazakov	Optimize calculation of reference FPS for the brushes (Show More…)	Oct 13 2017, 2:46 PM
115a4c3cf50d	091f254685c2	eb2e49b279a7 a892dea9f70e	Dmitry Kazakov	Merge remote-tracking branch 'origin/master' into kazakov/multithreaded-brushes	Oct 13 2017, 1:20 PM
eb2e49b279a7	1881af4bc5e3	ba953714cd83	Dmitry Kazakov	Move all the stroke speed metrics calculation into FreehandStroke (Show More…)	Oct 13 2017, 1:06 PM
ba953714cd83	baedebb92eee	f1bae7acac2d 1183debcf3bd	Dmitry Kazakov	Merge remote-tracking branch 'origin/master' into kazakov/multithreaded-brushes (Show More…)	Oct 12 2017, 10:15 AM
f1bae7acac2d	872162a12a16	4e2cff2ad3df	Dmitry Kazakov	Don't recalculate device extent too often (Show More…)	Oct 11 2017, 5:37 PM
4e2cff2ad3df	a2a89129efee	f3f864499ed8	Dmitry Kazakov	Recycle KisFixedPaintDevice objects thoughout the lifetime of KisBrushOp (Show More…)	Oct 11 2017, 5:15 PM
f3f864499ed8	6c999a961a3f	78df41469bae	Dmitry Kazakov	Post updates to the scheduler in bunches (Show More…)	Oct 11 2017, 1:06 PM
78df41469bae	78b506520e19	13e2576e184e	Dmitry Kazakov	Don't let paintop async update be entered twice	Oct 10 2017, 4:51 PM
13e2576e184e	f1d035cc4b0f	13f159e9013a	Dmitry Kazakov	Remove now unused no-fill dab generation method	Oct 10 2017, 3:46 PM
13f159e9013a	0d9cdecedd5b	28e049d17592	Dmitry Kazakov	Fix KisFixedPaintDevice not to refill the data all the time (Show More…)	Oct 10 2017, 3:22 PM
28e049d17592	5959687520fd	6c4109a60283	Dmitry Kazakov	Don't pass dirty node to the dab job (Show More…)	Oct 9 2017, 6:20 PM
6c4109a60283	7a4428dca9ca	cc8852a63740	Dmitry Kazakov	KisDabRenderingJob shouldn't be KisSharedRunnable anymore (Show More…)	Oct 9 2017, 6:14 PM
cc8852a63740	ba5dcda8545d	ab46e6977db0	Dmitry Kazakov	Use rolling mean wrapper in KisAnimationPlayer to avoid QtCreator's crashes (Show More…)	Oct 9 2017, 6:11 PM
ab46e6977db0	aa336bcfd649	859ac4950364	Dmitry Kazakov	Fix KisFigurePaintingToolHelper to update the image after the rendering is done	Oct 9 2017, 6:07 PM
859ac4950364	83afe66de869	0f1a20d37035	Dmitry Kazakov	Implement fake stroke jobs executor for usage in tests	Oct 9 2017, 5:56 PM
0f1a20d37035	d600ef1fdd0b	fa8ba8220afd	Dmitry Kazakov	Port KisBrushOp to use "mutated" and "uniquely concurrent" jobs (Show More…)	Oct 9 2017, 5:35 PM
fa8ba8220afd	4601a1bb1570	35afd76f537f	Dmitry Kazakov	Refactor addMutableJob() into addMutableJobs() (Show More…)	Oct 6 2017, 8:53 PM
35afd76f537f	c79f35635987	b1d2e33a8083	Dmitry Kazakov	Fix two crashes in a unittest	Oct 6 2017, 8:53 PM
b1d2e33a8083	f3e757539d4c	b3c74c7e3b0a	Dmitry Kazakov	Implement a concept of "Uniquely Concurrent" jobs for strokes system (Show More…)	Oct 6 2017, 2:33 PM
b3c74c7e3b0a	4882bfff983c	c18752b5fcd5	Dmitry Kazakov	Implement mutated jobs framework (Show More…)	Oct 5 2017, 3:37 PM
c18752b5fcd5	0dbbc98c11c3	236c8ca9160e	Dmitry Kazakov	Fix KisStrokesQueueTest (Show More…)	Oct 5 2017, 12:28 PM
236c8ca9160e	7314030fbc80	0a69adbbd792	Dmitry Kazakov	Implement simple stroke speed measurement logging (Show More…)	Sep 30 2017, 2:43 PM
0a69adbbd792	032540d2dd49	2ce8510564f3	Dmitry Kazakov	Don't expose current paintop from the helper (Show More…)	Sep 30 2017, 2:41 PM
2ce8510564f3	2cc9fcb50b21	b4b654940ffc	Dmitry Kazakov	Implement a utility class for measuring the speed of the stroke rendering	Sep 30 2017, 2:37 PM
b4b654940ffc	45b80eb19011	bf7aeb1add39	Dmitry Kazakov	Fix crash when trying to paint with colorsmudge paintop (Show More…)	Sep 30 2017, 8:40 AM
bf7aeb1add39	8c002db0f37e	e36632e0fc94	Dmitry Kazakov	Rewrite massive bltFixed(rect, dabs) implementation (Show More…)	Sep 29 2017, 7:30 PM
e36632e0fc94	2fe245b711bd	9b2e1454856a	Dmitry Kazakov	Implement a debugging class for measuring statistical distribution of values (Show More…)	Sep 29 2017, 6:53 PM
9b2e1454856a	051cc023985f	00aad4b22209	Dmitry Kazakov	Use KisRollingMeanAccumulatorWrapper in KisDabRenderingQueue (Show More…)	Sep 29 2017, 6:47 PM
00aad4b22209	209a277bb099	43908f87d45b	Dmitry Kazakov	Implement KisRollingMeanAccumulatorWrapper to prevent QtCreator from crashing (Show More…)	Sep 29 2017, 6:46 PM
43908f87d45b	1fc61ff2b658	73e358878a85	Dmitry Kazakov	Don't recalculate an adjustment layer, which is in invisible passthrough group (Show More…)	Sep 26 2017, 2:45 PM
73e358878a85	b00cecfe14d5	916e7e28dd9c	Dmitry Kazakov	Fix crash in threaded brush (Show More…)	Sep 26 2017, 2:43 PM
916e7e28dd9c	64e12d30d0a1	e457e3731ac7	Dmitry Kazakov	Deinitialize Python-based dockers when the last document is closed (Show More…)	Sep 26 2017, 9:05 AM
e457e3731ac7	e1726f946e57	bdb2e7fc2d75	Dmitry Kazakov	Fix crash when opening a document after closing the previous one (Show More…)	Sep 26 2017, 8:53 AM
bdb2e7fc2d75	78bd1f3acffc	16af18477079	Dmitry Kazakov	KisMimeDatabase should contain suffixes without '*.' prefix (Show More…)	Sep 22 2017, 6:39 PM
16af18477079	f87c1b649203	b62f9ba00d8a	Dmitry Kazakov	Implement selection handling when rendering massive bitBlt	Sep 22 2017, 4:17 PM
b62f9ba00d8a	7694cc11bf76	455e7020ae83	Dmitry Kazakov	Implement mirroring of the multithreaded brush	Sep 22 2017, 2:49 PM
455e7020ae83	71fc2322dfe8	4f1c090ecefb	Dmitry Kazakov	Implement Color Source and Sharpness/Texturing postprocessings for threaded… (Show More…)	Sep 21 2017, 1:56 PM
4f1c090ecefb	0c24284df92c	d82e9393fdf1	Dmitry Kazakov	Ensure all the dabs are generated before issuing the very last update (Show More…)	Sep 20 2017, 7:37 PM
d82e9393fdf1	76b9524fecd8	e03e95338b7d	Dmitry Kazakov	Fix crash when the queue was destroyed before the pool ended	Sep 20 2017, 7:00 PM
e03e95338b7d	eb9888f5362f	82dcd6efc277	Dmitry Kazakov	Implement the first version of the multithreaded Pixel Brush (Show More…)	Sep 20 2017, 3:23 PM
82dcd6efc277	06811ee7e82d	a1979311f392	Dmitry Kazakov	Fix saving of lastly used video encoding options	Sep 15 2017, 2:55 PM
a1979311f392	c9e0ee5a2674	148c409abc62	Dmitry Kazakov	Fix saving of 16f and 32f images into PNG (Show More…)	Sep 15 2017, 2:54 PM
148c409abc62	96d3a24271d0	f1a0cae11123	Dmitry Kazakov	Add a comparison operator to KisDabShape	Sep 15 2017, 11:57 AM
f1a0cae11123	d8963ed0155c	5bb1900972b7	Dmitry Kazakov	Implement a caching queue for multithreaded dab generation (Show More…)	Sep 15 2017, 11:56 AM
5bb1900972b7	cd19b91ee9fc	b5b456eb7773	Dmitry Kazakov	Implement KisSharedThreadPoolAdapter concept (Show More…)	Sep 15 2017, 11:46 AM
b5b456eb7773	c2cfff35880c	18e3c7a10140	Dmitry Kazakov	Refactor KisDabCache into two smaller classes (Show More…)	Sep 13 2017, 6:41 AM
18e3c7a10140	6ba08df8c9a5	9dcc522b9931	Dmitry Kazakov	Refactor KisPaintInformation to not keep a link to KisDistanceInformation (Show More…)	Sep 13 2017, 6:14 AM
9dcc522b9931	903e13f760dd	a0b8649a4565	Dmitry Kazakov	Implement KisPainter::bltFixed() that can merge multiple dabs at once (Show More…)	Aug 18 2017, 7:42 AM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	21732	d2eb072		Nov 1 2017, 9:15 PM	★	★

Merge multithreaded version of Pixel Brush into masterClosedPublicActions

Details

Diff Detail

Large Diff

Revision ContentsChangeset List

Diff 21732

libs/brush/kis_auto_brush.cpp

libs/brush/kis_brush.h

libs/brush/kis_brush.cpp

libs/brush/kis_brushes_pipe.h

libs/brush/kis_dab_shape.h

libs/brush/kis_gbr_brush.h

libs/brush/kis_gbr_brush.cpp

libs/brush/kis_imagepipe_brush.h

libs/brush/kis_imagepipe_brush.cpp

libs/brush/kis_text_brush.h

libs/brush/kis_text_brush.cpp

libs/brush/tests/kis_gbr_brush_test.h

libs/brush/tests/kis_gbr_brush_test.cpp

libs/brush/tests/kis_imagepipe_brush_test.cpp

libs/global/CMakeLists.txt

libs/global/KisRollingMeanAccumulatorWrapper.h

libs/global/KisRollingMeanAccumulatorWrapper.cpp

libs/global/KisSharedRunnable.h

libs/global/KisSharedRunnable.cpp

libs/global/KisSharedThreadPoolAdapter.h

libs/global/KisSharedThreadPoolAdapter.cpp

libs/global/tests/CMakeLists.txt

libs/global/tests/KisSharedThreadPoolAdapterTest.h

libs/global/tests/KisSharedThreadPoolAdapterTest.cpp

libs/image/CMakeLists.txt

libs/image/KisFakeRunnableStrokeJobsExecutor.h

libs/image/KisFakeRunnableStrokeJobsExecutor.cpp

libs/image/KisRenderedDab.h

libs/image/KisRunnableBasedStrokeStrategy.h

libs/image/KisRunnableBasedStrokeStrategy.cpp

libs/image/KisRunnableStrokeJobData.h

libs/image/KisRunnableStrokeJobData.cpp

libs/image/KisRunnableStrokeJobsInterface.h

libs/image/KisRunnableStrokeJobsInterface.cpp

libs/image/KisStrokesQueueMutatedJobInterface.h

libs/image/KisStrokesQueueMutatedJobInterface.cpp

libs/image/KisUpdaterContextSnapshotEx.h

libs/image/brushengine/KisStrokeSpeedMeasurer.h

libs/image/brushengine/KisStrokeSpeedMeasurer.cpp

libs/image/brushengine/kis_paint_information.h

libs/image/brushengine/kis_paint_information.cc

libs/image/brushengine/kis_paintop.h

libs/image/brushengine/kis_paintop.cc

libs/image/brushengine/kis_paintop_settings.h

libs/image/brushengine/kis_paintop_settings.cpp

libs/image/brushengine/kis_paintop_utils.h

libs/image/brushengine/kis_paintop_utils.cpp

libs/image/generator/kis_generator_layer.h

libs/image/generator/kis_generator_layer.cpp

libs/image/kis_brush_mask_applicators.h

libs/image/kis_distance_information.h

libs/image/kis_distance_information.cpp

libs/image/kis_fixed_paint_device.h

libs/image/kis_fixed_paint_device.cpp

libs/image/kis_image.h

libs/image/kis_image.cc

libs/image/kis_image_animation_interface.h

libs/image/kis_image_animation_interface.cpp

libs/image/kis_node.h

libs/image/kis_node.cpp

libs/image/kis_node_graph_listener.h

libs/image/kis_node_graph_listener.cpp

libs/image/kis_painter.h

libs/image/kis_painter.cc

libs/image/kis_painter_blt_multi_fixed.cpp

libs/image/kis_painter_p.h

libs/image/kis_projection_updates_filter.h

libs/image/kis_projection_updates_filter.cpp

libs/image/kis_simple_update_queue.h

libs/image/kis_simple_update_queue.cpp

libs/image/kis_stroke.h

libs/image/kis_stroke.cpp

libs/image/kis_stroke_job.h

libs/image/kis_stroke_job_strategy.h

Merge multithreaded version of Pixel Brush into master
ClosedPublic
Actions

Revision Contents
Changeset List