Differential D8523

Use native separators while copying filename to clipboard
ClosedPublic
Actions

Authored by geetamc on Oct 27 2017, 2:19 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:9d6aa08f7e59: Use native separators while copying filename to clipboard
Summary

Currently, on Windows the copied filename contains forward slashes.
The patch fixes that.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
geetamc created this revision.Oct 27 2017, 2:19 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptOct 27 2017, 2:19 PM
geetamc updated this revision to Diff 21482.Oct 28 2017, 11:00 AM
  • fixed weird indentation
kfunk accepted this revision.Oct 28 2017, 4:41 PM
This revision is now accepted and ready to land.Oct 28 2017, 4:41 PM
Closed by commit R32:9d6aa08f7e59: Use native separators while copying filename to clipboard (authored by geetamc, committed by kfunk). · Explain WhyOct 28 2017, 4:42 PM
This revision was automatically updated to reflect the committed changes.
kfunk added a comment.Oct 28 2017, 4:44 PM

@geetamc Note: Please fixup your user name to in Git (git config user.name).

I needed to amend your patch in order to fix this issue:

remote: Audit failure - Commit 55f2f00c8376837c9084b36413ae45b3f5652569 - Non-full name: Geetam
remote: FATAL: VREF/kde-update-checks: helper program exit status 256
remote: Push declined - commits failed audit

Thanks for the patch!

geetamc added a comment.Oct 28 2017, 6:12 PM
In D8523#161270, @kfunk wrote:

@geetamc Note: Please fixup your user name to in Git (git config user.name).

I needed to amend your patch in order to fix this issue:

remote: Audit failure - Commit 55f2f00c8376837c9084b36413ae45b3f5652569 - Non-full name: Geetam
remote: FATAL: VREF/kde-update-checks: helper program exit status 256
remote: Push declined - commits failed audit

Thanks for the patch!

Oh, sorry for that.

Revision Contents
Changeset List

PathPackages
Mkdevplatform/sublime/container.cpp (7 lines)

Diff 21500

View Options

kdevplatform/sublime/container.cpp

Loading...