Adjusted scrollbars to fit the Qt theme
Needs ReviewPublic

Authored by dos on Oct 25 2017, 7:14 PM.

Details

Reviewers
None
Group Reviewers
Breeze
Plasma

Diff Detail

Repository
R98 Breeze for Gtk
Lint
Lint Skipped
Unit
Unit Tests Skipped
dos created this revision.Oct 25 2017, 7:14 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 25 2017, 7:14 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol added a subscriber: apol.Oct 25 2017, 11:05 PM

In such reviews a before & after screenshot works great. :)

dos added a comment.Oct 25 2017, 11:25 PM

There you are :) Firefox, System Settings and gedit, before and after.

We recently adjusted the gtk3 scrollbars (see D6688), I'm not sure why your Qt scrollbars are so tiny... (maybe hi-DPI related?)

dos added a comment.Oct 26 2017, 6:21 PM

Oh, so it's a bug? I hope it doesn't get fixed then, as the tiny scrollbars look way better :D

mart added a subscriber: mart.Oct 30 2017, 2:38 PM

scrollbars are smaller by purpose now, so no, not a bug

mart added a comment.Oct 30 2017, 2:39 PM

as long qt and gtk will scale the same factor on dpi change, it should be good

dos abandoned this revision.Jan 24 2018, 1:27 AM

Although I really like smaller scrollbars and will keep them in my gtkrc, it turns out it's not really intended in Qt - my session had DPI adjusted only by font setting, the screen scaling factor was still 1. After adjusting the screen scaling factor, the scrollbars became fatter :( So, closing it.

dos reclaimed this revision.Jan 24 2018, 4:29 PM

Turns out the scrollbar now got changed indeed and is going to be configurable in 5.13, including extra slim option like the one this implements. So, I'm reopening this now, although it sure will need some adjustments.