Differential D8378

Start the text generation request via a queued connection
ClosedPublic
Actions

Authored by aacid on Oct 20 2017, 10:19 AM.

Details

Reviewers
mlaurent
Group Reviewers
Okular
Commits
R223:453f45e7f798: Start the text generation request via a queued connection
Summary

so that pixmap generation gets a chance to start before the text generation

This makes that on files where both the text generation and the pixmap generation
are slow at least we see something "as fast as possible" since only either text generation
or pixmap generation threads run at the same time

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Oct 20 2017, 10:19 AM
Restricted Application added a project: Okular. · View Herald TranscriptOct 20 2017, 10:19 AM
Restricted Application added a subscriber: Okular. · View Herald Transcript
mlaurent accepted this revision.Oct 20 2017, 12:54 PM
mlaurent added a subscriber: mlaurent.

Seems ok for me.

This revision is now accepted and ready to land.Oct 20 2017, 12:54 PM
dvratil added a subscriber: dvratil.Oct 20 2017, 12:56 PM
dvratil added inline comments.
core/generator.cpp
255–256

s/change/chance/

256

normalize Q_ARG signature (Okular::Page * vs Okular::Page*)

aacid updated this revision to Diff 21010.Oct 20 2017, 1:21 PM

Fixed typo and normalized Q_ARG signature

aacid marked 2 inline comments as done.Oct 20 2017, 1:22 PM
mlaurent requested changes to this revision.Oct 25 2017, 9:33 AM
mlaurent added inline comments.
core/generator_p.h
135

it seems that okular use Q_SLOTS

This revision now requires changes to proceed.Oct 25 2017, 9:33 AM
aacid updated this revision to Diff 21351.Oct 26 2017, 8:10 AM

slots -> Q_SLOTS

aacid marked an inline comment as done.Oct 26 2017, 8:10 AM
mlaurent accepted this revision.Oct 30 2017, 4:56 PM
This revision is now accepted and ready to land.Oct 30 2017, 4:56 PM
Closed by commit R223:453f45e7f798: Start the text generation request via a queued connection (authored by aacid). · Explain WhyOct 31 2017, 9:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcore/generator.cpp (3 lines)
Mcore/generator_p.h (9 lines)

Diff 21608

View Options

core/generator.cpp

Loading...
View Options

core/generator_p.h

Loading...