Prepare for AtCore beta release
ClosedPublic

Authored by rizzitello on Oct 19 2017, 10:58 PM.

Diff Detail

Repository
R232 AtCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello created this revision.Oct 19 2017, 10:58 PM
tcanabrava accepted this revision.Oct 20 2017, 11:34 AM

cool.
+1.

This revision is now accepted and ready to land.Oct 20 2017, 11:34 AM

Maybe would be nice to have the commit id in help/about or something like this in testclient.

Maybe would be nice to have the commit id in help/about or something like this in testclient.

I was not going to make an about dialog in the test gui. The commit id I will use for part of the -git package name, something like atcore-git-VERSION-GITID-BUILD#.

rizzitello updated this revision to Diff 21053.Oct 21 2017, 1:26 PM
  • Add About Box
laysrodrigues requested changes to this revision.Oct 21 2017, 1:34 PM

I think that you can remove the AtCore string beside the logo, is redundant.
And the strings, version git you can move to below the image, will look better.

This revision now requires changes to proceed.Oct 21 2017, 1:34 PM
rizzitello updated this revision to Diff 21054.Oct 21 2017, 2:02 PM
  • No UI file
rizzitello updated this revision to Diff 21057.Oct 21 2017, 2:41 PM
  • Adjust about box layout
rizzitello updated this revision to Diff 21081.Oct 21 2017, 7:19 PM
  • If built from a git checked out folder version number will have git id appended
rizzitello updated this revision to Diff 21082.Oct 21 2017, 7:38 PM
  • Patrick Suggestions
rizzitello updated this revision to Diff 21084.Oct 21 2017, 7:40 PM
  • Remove extra empty line
  • Fix about copyright year
  • Remove stray \ in about author text
laysrodrigues accepted this revision.Oct 23 2017, 12:44 AM

You are good to go =D

This revision is now accepted and ready to land.Oct 23 2017, 12:44 AM
This revision was automatically updated to reflect the committed changes.