Use QActions directly in menu
ClosedPublic

Authored by broulik on Oct 18 2017, 1:37 PM.

Details

Summary

Instead of duplicating the name and icon work, just bind it to the QAction itself. Also respect visibility of actions for KIOSK restriction.

Test Plan

It now uses System Settings app icon for "About System Settings" instead of "help-about", though.
Placed the following in kdeglobals

[KDE Action Restrictions]
action/configure=false

Action would no longer show up. It would never trigger as the action was disabled internally so this is purely cosmetic.

Diff Detail

Repository
R124 System Settings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Oct 18 2017, 1:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 18 2017, 1:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Oct 18 2017, 6:20 PM
This revision is now accepted and ready to land.Oct 18 2017, 6:20 PM
This revision was automatically updated to reflect the committed changes.