Add physicalSize to the Screens API
ClosedPublic
Actions

Authored by graesslin on Oct 17 2017, 4:47 PM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

R108:02d3daf28a47: Add physicalSize to the Screens API

Summary

Allows to share the implementation in a better way and is a requirement
to get the Screen implementation in the QPA plugin to be based on
KWin::Screens instead of KWayland::Output.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Oct 17 2017, 4:47 PM

Restricted Application added a project: KWin. · View Herald TranscriptOct 17 2017, 4:47 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin added a dependent revision: D8345: [QPA] Implement Screen on top of internal Screens API.Oct 17 2017, 5:20 PM

mart accepted this revision.Oct 17 2017, 5:46 PM

This revision is now accepted and ready to land.Oct 17 2017, 5:46 PM

Closed by commit R108:02d3daf28a47: Add physicalSize to the Screens API (authored by graesslin). · Explain WhyOct 19 2017, 4:03 PM

This revision was automatically updated to reflect the committed changes.

bshah added a subscriber: bshah.Oct 23 2017, 4:19 AM

bshah added inline comments.

plugins/platforms/hwcomposer/hwcomposer_backend.cpp
197	This breaks the build.. will fix it however. /workspace/build/plugins/platforms/hwcomposer/hwcomposer_backend.cpp: In function ‘KWayland::Server::OutputInterface* KWin::createOutput(hwc_composer_device_1_t)’: /workspace/build/plugins/platforms/hwcomposer/hwcomposer_backend.cpp:197:10: error: ‘m_physicalSize’ was not declared in this scope m_physicalSize = QSizeF(qreal(pixel.width() 1000) / qreal(attr_values[2]) * factor,

plugins/platforms/hwcomposer/hwcomposer_backend.cpp

197

This breaks the build.. will fix it however.

/workspace/build/plugins/platforms/hwcomposer/hwcomposer_backend.cpp: In function ‘KWayland::Server::OutputInterface* KWin::createOutput(hwc_composer_device_1_t*)’:
/workspace/build/plugins/platforms/hwcomposer/hwcomposer_backend.cpp:197:10: error: ‘m_physicalSize’ was not declared in this scope
          m_physicalSize = QSizeF(qreal(pixel.width() * 1000) / qreal(attr_values[2]) * factor,

This breaks the build.. will fix it however.

Tricky, the method using m_physicalSize is static method, would it cause any issue if I make m_physicalSize also static?

In D8344#158553, @bshah wrote:

This breaks the build.. will fix it however.

Tricky, the method using m_physicalSize is static method, would it cause any issue if I make m_physicalSize also static?

Maybe there is no need to have that method static?

Sorry about the build failure...

In D8344#158566, @graesslin wrote:

Maybe there is no need to have that method static?

Sorry about the build failure...

Yeah, going by that theory, will put patch in phab in moment.

Revision Contents
Changeset List

			Path	Packages
M			plugins/platforms/drm/drm_output.h (5 lines)
M			plugins/platforms/drm/drm_output.cpp (1 line)
M			plugins/platforms/drm/screens_drm.h (2 lines)
M			plugins/platforms/drm/screens_drm.cpp (9 lines)
M			plugins/platforms/hwcomposer/hwcomposer_backend.h (4 lines)
M			plugins/platforms/hwcomposer/hwcomposer_backend.cpp (5 lines)
M			plugins/platforms/hwcomposer/screens_hwcomposer.h (1 line)
M			plugins/platforms/hwcomposer/screens_hwcomposer.cpp (9 lines)
M			screens.h (7 lines)
M			screens.cpp (5 lines)
M			wayland_server.cpp (2 lines)