[QPA] Implement Screen on top of internal Screens API
ClosedPublic

Authored by graesslin on Oct 17 2017, 5:20 PM.

Details

Summary

The test DontCrashUseractionsMenu (Waylandonly) found an issue in our
screen handling implementation in the QPA. The code exposed a short time
frame between the dummy screen getting destroyed and the first screen
being added. This could result in a crash of KWin.

There is actually no need to implement Screen on top of Wayland screen.
KWin has all the knowledge, so we can also base this on top of the
Screens API.

Advantages:

  • no delays due to Wayland roundtrips
  • handle screen getting removed (was a TODO)
  • handle resolution changes (was a TODO)

The new implementation has a disadvantage that it destroys and readds
all screens whenever something around the screen changes. This shouldn't
be an issue in practice as it's only for the internal QPA and thus only
affects KWin internal windows which is placed in global coordinates
anyway. If it turns out to be a problem we need to track better the
screen changes - so far those were not tracked at all.

Test Plan

Run a few unit tests which change screens

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Oct 17 2017, 5:20 PM
Restricted Application added a project: KWin. · View Herald TranscriptOct 17 2017, 5:20 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Oct 18 2017, 8:56 AM
This revision is now accepted and ready to land.Oct 18 2017, 8:56 AM
This revision was automatically updated to reflect the committed changes.