Differential D8338

Set transient parent for system tray menus
ClosedPublic
Actions

Authored by davidedmundson on Oct 16 2017, 10:37 PM.

Details

Reviewers
mart
graesslin
Group Reviewers
Plasma
Commits
R120:2ff7b3e22158: Set transient parent for system tray menus
Summary

BUG: 381174

Test Plan

Had debug in QtWayland
Clicked on systray
Had parent, menu was in the right position

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added a project: Plasma. · View Herald TranscriptOct 16 2017, 10:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin added a subscriber: graesslin.Oct 17 2017, 4:19 AM

Looks good!

startkde/startplasma.cmake
31–32 ↗(On Diff #20887)

This looks unrelated.

davidedmundson updated this revision to Diff 20887.Oct 17 2017, 5:58 AM

Remove irrelevant code

mart accepted this revision.Oct 17 2017, 7:46 AM
This revision is now accepted and ready to land.Oct 17 2017, 7:46 AM
apol added a subscriber: apol.Oct 17 2017, 9:52 AM
apol added inline comments.
applets/systemtray/systemtray.cpp
216

This looks wrong...

graesslin accepted this revision.Oct 17 2017, 3:56 PM
graesslin added inline comments.
applets/systemtray/systemtray.cpp
216

nah, it's the common trick to create the windowHandle. Without the next line of code would crash. Don't ask me why Qt doesn't have proper API for it...

Closed by commit R120:2ff7b3e22158: Set transient parent for system tray menus (authored by davidedmundson). · Explain WhyOct 18 2017, 10:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20888

View Options

applets/systemtray/systemtray.cpp

Loading...
View Options

startkde/startplasma.cmake

Loading...