Differential D8276

[SideBar] enable LayoutMirroring for RTL
ClosedPublic
Actions

Authored by ttv20 on Oct 13 2017, 1:50 PM.

Details

Reviewers
broulik
davidedmundson
Summary

Just fix RTL and fix the back arrow on SubCategoryPage

Test Plan

tested on hebrew (RTL) and english (LTR)
Everything seemed to be expected

Diff Detail

Repository
R124 System Settings
Lint
Lint Skipped
Unit
Unit Tests Skipped
ttv20 created this revision.Oct 13 2017, 1:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 13 2017, 1:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ttv20 added a comment.Oct 13 2017, 2:01 PM

Before (subcategory is right to category):


after:

Before (in narrow screen, arrow is flipped):


after:

davidedmundson accepted this revision.Oct 13 2017, 2:58 PM
davidedmundson added a subscriber: davidedmundson.

thanks.

Do you have commit access?

This revision is now accepted and ready to land.Oct 13 2017, 2:58 PM
ttv20 added a comment.Oct 15 2017, 5:09 AM

I think I've because I'm translator

progwolff added a subscriber: progwolff.EditedOct 18 2017, 9:49 AM

Is it just for me, or is the layout mirrored unconditionally now?

ttv20 added a comment.Oct 18 2017, 12:06 PM
In D8276#156785, @progwolff wrote:

Is it just for me, or is the layout mirrored unconditionally now?

My mistake
Committed fix - https://commits.kde.org/systemsettings/0008f304f8a434d0a6593802ef4a1eee8a8613d6

Revision Contents
Changeset List

Diff 20678

View Options

sidebar/package/contents/ui/SubCategoryPage.qml

Loading...
View Options

sidebar/package/contents/ui/main.qml

Loading...