Differential D8186

Fix fps output of macOS
ClosedPublic
Actions

Authored by poke1024 on Oct 8 2017, 7:49 AM.

Details

Reviewers
rempt
Group Reviewers
Krita
Summary

Fixes fps decoration output on canvas on macOS.

Before:

After:

Works around a QT bug; I tried glFinish() and the like to no avail.

For all platforms: limits the fps output to one decimal place.

Test Plan

Turn on fps output in the performance settings on macOS.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
poke1024 created this revision.Oct 8 2017, 7:49 AM
poke1024 updated this revision to Diff 20461.Oct 8 2017, 7:51 AM

the previous version was my debugging version :-)

alvinhochun added a subscriber: alvinhochun.Oct 8 2017, 8:35 AM

Is the Qt bug reported and is there a link to said bug?

poke1024 added a comment.Oct 8 2017, 10:14 AM

@alvinhochun Doesn't seem to be officially reported yet, though it popped up in the forums:

https://forum.qt.io/topic/77307/qpainter-draw-text-renders-the-text-into-some-weird-characters

There have been graphics driver problems reported with this before:

https://bugreports.qt.io/browse/QTBUG-51216

rempt accepted this revision.Oct 9 2017, 8:48 AM
This revision is now accepted and ready to land.Oct 9 2017, 8:48 AM
poke1024 closed this revision.Oct 16 2017, 2:34 PM
alvinhochun added a comment.Nov 3 2017, 4:47 PM
In D8186#153211, @poke1024 wrote:

@alvinhochun Doesn't seem to be officially reported yet, though it popped up in the forums:

https://forum.qt.io/topic/77307/qpainter-draw-text-renders-the-text-into-some-weird-characters

There have been graphics driver problems reported with this before:

https://bugreports.qt.io/browse/QTBUG-51216

Hm, I just realized that these links both says the issue only appears on Windows and works fine on Linux and OS X, but you have it on OS X... Would it be fine to just enable the fix for all platforms?

poke1024 reopened this revision.Nov 6 2017, 1:28 PM
poke1024 added a subscriber: woltherav.

@woltherav says that this is needed on Linux and Windows as well, so I'll update this to get enabled on all platforms

This revision is now accepted and ready to land.Nov 6 2017, 1:28 PM
alvinhochun closed this revision.Nov 7 2017, 1:35 PM

If anything I'd say just make a new patch based on master, it'd get messy if you try to change this review since it's already committed and closed.

Revision Contents
Changeset List

Diff 20461

View Options

libs/ui/kis_fps_decoration.h

Loading...
View Options

libs/ui/kis_fps_decoration.cpp

Loading...