- empty document does not resize bar widget when spell check is started without effect
- replacing the last word with an empty text does not leave the progress bar open
- show first suggestion in suggestion combo box
- clear replace-all-list when checking is finished
Details
Details
- Reviewers
dhaumann - Group Reviewers
KTextEditor - Commits
- R39:06ab983c7a3d: Minor spell check interface fixes
- perform spell check on empty document
- replace trailing misspelled word in document with empty string
- recheck spelling of former "Replace All" word
Diff Detail
Diff Detail
- Repository
- R39 KTextEditor
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/spellcheck/spellcheckbar.cpp | ||
|---|---|---|
| 146 | This might have been a feature, but without clearing the map, there is no way to revert a "Replace All"-word, except for restarting the editor. | |
Comment Actions
Looks already quite good. Btw, are there any bug reports in the Kate or frameworks-ktexteditor product on bugs.kde.org that you fix here?
| src/spellcheck/spellcheckdialog.cpp | ||
|---|---|---|
| 198 | Hm, could you explain why removing this line is correct? Is it because in line 202 we continue with the replacementStartCursor anyway? | |
Comment Actions
I didn't find one. I just discovered these yesterday and don't think anybody could investigate this with the spell check bar working only once (for whom and since when, I don't know. Bug 359682 dated back to 02-2016).
| src/spellcheck/spellcheckdialog.cpp | ||
|---|---|---|
| 198 | Yes, the m_currentSpellCheckRange is invalidated in any case, so there is no reason to set its range here. | |