Add encryptionDetails to the messageviewer.
ClosedPublic

Authored by knauss on Oct 2 2017, 12:39 PM.

Details

Summary

Sometimes you want to see for what keys the message was encrypted. One
example is, if you awnser and need first to download the corresponding
key.

Test Plan

open encrypted message

not decrypted:

encrypted with light theme:

encrypted with light theme (expanded info):

encrypted with light theme (failed to encrypt):

encrypted with dark theme:

encrypted with dark theme (expanded info):

encrypted with dark theme (failed to encrypt):

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss created this revision.Oct 2 2017, 12:39 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 2 2017, 12:39 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

Also i havn't updated all the tests, becuase before the wording and style needs to be clear :)

Okay how it looks:

not decrypted:

decryption failed with unknown keys:

encryption passed (Default, see the "Show details" in the right corner blue-in-blue):

encryption passed (with details):

encryption passed (with details, marked so it is readable :):

Also for breeze normal the blue-in-blue is hard to read. (@colomar: do you have an good idea what color to use for the links inside encryption part)
For sure we want to change the color of the links :)

Colors are more @jensreuterberg 's thing.

I have two small comments on the wording, though:

  1. "It is encrypted for the following keys"
  2. "The message is encrypted for the following keys"

@jensreuterberg: can you give any time, when you be able to look at the color issue here?

knauss added a subscriber: VDG.Oct 18 2017, 9:47 AM
knauss edited the test plan for this revision. (Show Details)Oct 24 2017, 10:46 PM
knauss edited the test plan for this revision. (Show Details)Oct 24 2017, 10:49 PM
knauss updated this revision to Diff 21263.EditedOct 24 2017, 10:51 PM

Now configure colors for encryption block more soft.

Makes links in encryption block better readable.

This revision was automatically updated to reflect the committed changes.

@jensreuterberg , @colomar: i pushed the patch for the time beeing - if you have improvements for the colors etc. feel free to contact me :)