Better drop indicator for the layer panel
ClosedPublic

Authored by poke1024 on Sep 29 2017, 11:37 AM.

Details

Reviewers
rempt
dkazakov
Group Reviewers
Krita
Summary

Currently the drop indicators in the layers panel are a thin black line for inserting above or below and a thin black frame for inserting inside.

This adds a thicker colored insertion marker for inserting above/below and a filled box marker for inserting inside:


Note that there is some code in KisNodeView::paintEvent that seems to paint its own drop indicator for some situations - it doesn't get called for the layer panel and I didn't touch it.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
poke1024 created this revision.Sep 29 2017, 11:37 AM
Deevad added a subscriber: Deevad.Sep 29 2017, 11:57 AM

I really like the little polishing you are doing on the user interface. Well thought!
Sure, thicker colored line will help to see the future layer position.

rempt accepted this revision.Sep 29 2017, 2:44 PM
rempt added a subscriber: rempt.

Note that there is some code in KisNodeView::paintEvent that seems to paint its own drop indicator for some situations - it doesn't get called for > the layer panel and I didn't touch it.

That could just be very old code: maybe we can just remove it, if it is no longer used after Dmitry's layer box refactoring of 2015/16..

This revision is now accepted and ready to land.Sep 29 2017, 2:44 PM
dkazakov accepted this revision.Oct 3 2017, 9:13 AM
dkazakov added a subscriber: dkazakov.

Tested it, works nicely :)

woltherav closed this revision.Oct 5 2017, 6:14 PM