Differential D8030

Brightness and contrast sliders for brush textures
ClosedPublic
Actions

Authored by radianart on Sep 28 2017, 1:15 PM.

Details

Reviewers
dkazakov
rempt
Commits
R37:32891ee60fbc: Add brightness and contrast sliders for textured brushes
R37:f9ac29f5680c: Add brightness and contrast sliders for textured brushes
Summary

I'm not sure I made contrast good way.
Also I'm not sure about mask value check.

But both functions works pretty well, saves and loads with brush presets and doesn't affect previously saved presets (=doesn't mess up default presets).

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
radianart created this revision.Sep 28 2017, 1:15 PM
rempt added a comment.Sep 29 2017, 10:42 AM

I'm all for it, but the sliders should be as wide as the other sliders in the widget.

radianart added a comment.Sep 29 2017, 1:14 PM
In D8030#150429, @rempt wrote:

I'm all for it, but the sliders should be as wide as the other sliders in the widget.

Hm it looks alright on my pc. I thought it's because my build isn't very fresh but it's still same after git pull.
Or I should make it smaller?

Deevad added a subscriber: Deevad.Sep 29 2017, 1:57 PM

Tested. Very good addition @radianart ! This will definitely help to produce better textured presets.

rempt accepted this revision.Sep 29 2017, 2:42 PM

Weird then, I don't know why they were so small in my build. Please push :-)

This revision is now accepted and ready to land.Sep 29 2017, 2:42 PM
Closed by commit R37:f9ac29f5680c: Add brightness and contrast sliders for textured brushes (authored by rempt). · Explain WhySep 29 2017, 3:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20097

View Options

plugins/paintops/libpaintop/kis_texture_option.h

Loading...
View Options

plugins/paintops/libpaintop/kis_texture_option.cpp

Loading...