Differential D8014

Don't animate IconItem in software mode
AbandonedPublic
Actions

Authored by davidedmundson on Sep 27 2017, 2:41 PM.

Details

Reviewers
broulik
bcooksley
Group Reviewers
Plasma
Commits
R242:94235482f9ab: Don't animate IconItem in software mode
Summary

IconItem uses a gorgeous shader to fade between two states. This doesn't
work with software rendering.

Given software rendering is a second class citizen, just skip the
animation.

Test Plan

Hovered over kickoff.
Went from one to the other, without temporarily disappearing

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Sep 27 2017, 2:41 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptSep 27 2017, 2:41 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik accepted this revision.Sep 27 2017, 2:46 PM
This revision is now accepted and ready to land.Sep 27 2017, 2:46 PM
Closed by commit R242:94235482f9ab: Don't animate IconItem in software mode (authored by davidedmundson). · Explain WhySep 27 2017, 2:52 PM
This revision was automatically updated to reflect the committed changes.
bcooksley reopened this revision.Sep 29 2017, 8:37 AM
bcooksley added a subscriber: bcooksley.

Reopening - This breaks the build with Qt 5.7 based systems, which is the minimum requirement for Frameworks.

This revision is now accepted and ready to land.Sep 29 2017, 8:37 AM
bcooksley requested changes to this revision.Sep 29 2017, 8:37 AM
This revision now requires changes to proceed.Sep 29 2017, 8:37 AM
mart added a subscriber: mart.Sep 29 2017, 9:27 AM
mart added inline comments.
src/declarativeimports/core/iconitem.cpp
624

enclose this part with #ifdef on Qt version?

davidedmundson added a comment.Sep 29 2017, 9:31 AM

@mart Kai did it already.

davidedmundson abandoned this revision.Sep 29 2017, 12:35 PM

Revision Contents
Changeset List

Diff 19992

View Options

src/declarativeimports/core/iconitem.cpp

Loading...