Differential D7966

KComboBox: Reuse the existing completion object on new line edit
ClosedPublic
Actions

Authored by mwolff on Sep 24 2017, 11:48 AM.

Details

Reviewers
dfaure
Commits
R284:cf2f5c72d9f3: KComboBox: Reuse the existing completion object on new line edit
Summary

When a KComboBox was created and a completion object configured on
it, that setting was lost once the combo box was set to be editable.
To support this workflow and make the API easier to use, we now keep
the previous completion object alive and set it on the new line edit.

Diff Detail

Repository
R284 KCompletion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mwolff created this revision.Sep 24 2017, 11:48 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 24 2017, 11:48 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure accepted this revision.Sep 24 2017, 6:40 PM

Just to be sure, your unittest could also test the case of setEditable(false).

This revision is now accepted and ready to land.Sep 24 2017, 6:40 PM
Closed by commit R284:cf2f5c72d9f3: KComboBox: Reuse the existing completion object on new line edit (authored by mwolff). · Explain WhyNov 30 2017, 11:21 PM
This revision was automatically updated to reflect the committed changes.
mwolff added a comment.Nov 30 2017, 11:21 PM
In D7966#148641, @dfaure wrote:

Just to be sure, your unittest could also test the case of setEditable(false).

What should it test then? if it's not editable, there is no line edit, and thus no completion object?

Revision Contents
Changeset List

PathPackages
Mautotests/kcombobox_unittest.cpp (15 lines)
Msrc/kcombobox.cpp (7 lines)

Diff 23195

View Options

autotests/kcombobox_unittest.cpp

Loading...
View Options

src/kcombobox.cpp

Loading...