it makes possible to use kirigami's color sets
Details
Diff Detail
- Repository
- R858 Qt Quick Controls 2: Desktop Style
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
This is set to be a framework.
We can't have a framework that imports something from workspace.
org.kde.desktop/Label.qml | ||
---|---|---|
32 ↗ | (On Diff #19942) | This change is unrelated. |
plugin/kquickstyleitem.cpp | ||
167 | I don't understand what this is doing? It looks wrong? | |
709–711 | This area needs some tidying. Also we need this line if the palette isn't explicitly set to something else. |
it imports kirigami, which is a framework, so it just makes it tier2
org.kde.desktop/Label.qml | ||
---|---|---|
32 ↗ | (On Diff #19942) | it is as since StylePrivate is mostly binding QPalette colors, all its uses should be eventually removed |
plugin/kquickstyleitem.cpp | ||
167 | it's getting (and eventually creating if didn't exist yet) the attached property Kirigami.Theme, which is a subclass of the public symbol PlatformTheme, which is guaranteed to exist at that point | |
709–711 | definitely a mess, yeah :) |
plugin/kquickstyleitem.cpp | ||
---|---|---|
167 | I meant specifically the setInherit that's also exposed in QML and you have that being explicitly set there. |
plugin/kquickstyleitem.cpp | ||
---|---|---|
167 | ouch yeah, that's actually a leftover :) |
- use Kirigami Theme for colors
- clean dead code
- use kirigami colors
- get rid of SystemPaletteSingleton and TextSingleton
Is 5.39 tagged already?
kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp | ||
---|---|---|
48 ↗ | (On Diff #20296) | and disconnect from the old window |
82 ↗ | (On Diff #20296) | This is bad If some other place miles away in a random lib in a different place in the UI, sets a colour, it will be wrong. Why meddle with the global loader if you're passing it as an arg anyway? |
This code introduces a new dependency which has yet to be declared in the kde-build-metadata repository.
As this has been several days now, i'll be reverting this commit and any others which interfere in the revert process in 24 hours if this isn't corrected.