Differential D7940

plugin loaded by kirigami to use KColorScheme and KIconLoader
AbandonedPublic
Actions

Authored by mart on Sep 22 2017, 4:54 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Kirigami
Summary

plugin to load icons and colors from high tier frameworks
as KWidgetAddons and KiconThemes

Test Plan

loaded correctly: it will probably have to be in a different repo
as here may be problematic for distributions

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Branch
arcpatch-D7940
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Sep 22 2017, 4:54 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 22 2017, 4:54 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson added a subscriber: davidedmundson.Sep 25 2017, 9:03 AM
davidedmundson added inline comments.
src/kirigami-integration/plasmadesktoptheme.cpp
35

I can't find Kirigami::PlatformTheme? Is the review published?

src/kirigami-integration/plasmadesktoptheme.h
74

how are they legacy?

mart added inline comments.Sep 26 2017, 12:38 PM
src/kirigami-integration/plasmadesktoptheme.cpp
35

it's in the giant https://phabricator.kde.org/D7939

src/kirigami-integration/plasmadesktoptheme.h
74

should be better documented...
the idea is to go from
Rectangle {

color: Theme.viewBackgroundColor

}

to

Rectangle {

Theme.colorSet: Theme.View
color: Theme.backgroundColor

}

mart updated this revision to Diff 19944.Sep 26 2017, 3:35 PM
  • sync colors on palette change
Restricted Application added a project: Kirigami. · View Herald TranscriptSep 26 2017, 3:35 PM
mart updated this revision to Diff 20004.Sep 27 2017, 4:37 PM
  • support inactive palette for inactive windows
mart updated this revision to Diff 20047.Sep 28 2017, 4:18 PM
  • add missing roles
mart updated this revision to Diff 20102.Sep 29 2017, 4:09 PM
  • adapt to api change
mart updated this revision to Diff 20105.Sep 29 2017, 5:05 PM
  • don't connect to null object, warnings--
mart updated this revision to Diff 20109.Sep 29 2017, 6:07 PM
  • use new KIconLoader api
mart updated this revision to Diff 20111.Sep 29 2017, 6:19 PM

support icon coloring

mart abandoned this revision.Oct 3 2017, 2:25 PM

all the code is in D7941 now

Revision Contents
Changeset List

Diff 20111

View Options

CMakeLists.txt

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/kirigami-integration/CMakeLists.txt

Loading...
View Options

src/kirigami-integration/kirigamiplasmafactory.h

Loading...
View Options

src/kirigami-integration/kirigamiplasmafactory.cpp

Loading...
View Options

src/kirigami-integration/kirigamiplasmaintegration.json

Loading...
View Options

src/kirigami-integration/plasmadesktoptheme.h

Loading...
View Options

src/kirigami-integration/plasmadesktoptheme.cpp

Loading...