There are a few connections that I wasn't able to do the update. Like a signal isn't on the object class and others that I couldn't do the static _cast of overloaded functions right. But most of the signals were updated. There are some comments on the connects that I had a problem.

Here a some of the lines that I had problem:
https://github.com/KDE/kate/blob/master/addons/filetree/katefiletree.cpp#L162
https://github.com/KDE/kate/blob/master/addons/filetree/katefiletreemodel.cpp#L468
https://github.com/KDE/kate/blob/master/addons/filetree/katefiletreemodel.cpp#L830
https://github.com/KDE/kate/blob/master/addons/filetree/katefiletreeplugin.cpp#L185 (Here I used lambda because the issue was that the slot required more arguments than the signal sends, but the two are void on parameters)
https://github.com/KDE/kate/blob/master/addons/katebuild-plugin/plugin_katebuild.cpp#L919

I went over the diff, beside the few things not converted I see no obvious faults.
If nobody else objects, I would approve this.

For the parts that can't be converted: I would assume e.g.

connect(job, SIGNAL(data(KIO::Job *, QByteArray)),

this, SLOT(slotData(KIO::Job *, QByteArray)));

​ this, SLOT(slotData(KIO::Job *, QByteArray)));

should be convertable, too, but no time to take a look atm how if the trivial way didn't work.

Are we sure this doesn't add regressions? Somethings connections are also disconnected, and as far as I know, mixing a new-style connect with an old-style disconnect does not work. If we are sure this works, then I'm all for it.

PS: I did not go over the patch.

In D7851#147107, @dhaumann wrote:

Are we sure this doesn't add regressions? Somethings connections are also disconnected, and as far as I know, mixing a new-style connect with an old-style disconnect does not work. If we are sure this works, then I'm all for it.

PS: I did not go over the patch.

If I wasn't able to change the 'connect' to the new pattern, the disconnect was also not changed. Now about the regression, I can't say much. I know that this is a big patch and is hard to review all the changes.

Maybe it would be more readable with qOverload instead of static_cast? Although, that requires C++14...

In D7851#154698, @stikonas wrote:

Maybe it would be more readable with qOverload instead of static_cast? Although, that requires C++14...

... and Qt 5.7 => not feasible.

@dhaumann Any final words?