Fixes
BUG: 119929
Details
Details
- Reviewers
kfunk - Commits
- R33:be735d44a5ad: Setup QCollator into ctor instead of lessThan. Also, remove unneeded includes.
R32:be735d44a5ad: Setup QCollator into ctor instead of lessThan. Also, remove unneeded includes.
R33:fa0d28c15edd: [GCI] Use natural sorting in variable list
R32:fa0d28c15edd: [GCI] Use natural sorting in variable list
Tests passed and works as expected.
Diff Detail
Diff Detail
- Repository
- R33 KDevPlatform
- Branch
- natural_sort
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Looks great, thanks!
debugger/variable/variablesortmodel.cpp | ||
---|---|---|
31 ↗ | (On Diff #1845) | Nitpick: Indent this line |
39 ↗ | (On Diff #1845) | Also here, and everywhere else: No spaces inside (...) |
40 ↗ | (On Diff #1845) | const, same below |
debugger/variable/variablesortmodel.h | ||
31 ↗ | (On Diff #1845) | Nitpick: No indent inside namespaces please |
36 ↗ | (On Diff #1845) | nullptr |
debugger/variable/variablesortmodel.cpp | ||
---|---|---|
38 ↗ | (On Diff #1845) | this patch must be revised: The QCollator setup is afaik not cheap, and thus must not be done repeatedly inside ::lessThan. Please make it a member variable and put the initialization into the ctor. |