[ListItemBase] Open options menu on right click

Authored by broulik on Sep 7 2017, 3:12 PM.


Group Reviewers
Test Plan

The menu is still attached to the menu button regardless of where I click but I don't neccessarily need to aim for that tiny button anymore.

Middle click to mute still works.

Diff Detail

R115 Plasma Audio Volume Applet
Lint Skipped
Unit Tests Skipped
broulik created this revision.Sep 7 2017, 3:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 7 2017, 3:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik updated this revision to Diff 19275.Sep 7 2017, 3:13 PM
  • Also highlight menu button while context menu is open
drosca edited edge metadata.Sep 7 2017, 3:16 PM

We're back to the context menu discussion. But to me, this feels weird, the context menu should be opened under cursor.

We have *both* now. The visual menu button and the "non-discoverable" context menu accessible through right-clicking the entire area

Should we go for it or abandon this?

Should we go for it or abandon this?

If it gets +1 from VDG.

I'd also prefer for the menu to open under the mouse, if it's not ridiculously difficult to implement.

broulik planned changes to this revision.Dec 5 2019, 9:13 PM
broulik abandoned this revision.May 20 2020, 1:37 PM

Will revisit on GitLab. Code has changed too much