Differential D7614

[FrameSvg] Use QPixmap::mask() instead of deprecated convoluted way via alphaChannel()
ClosedPublic
Actions

Authored by broulik on Aug 30 2017, 9:46 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:5921b2a70ced: [FrameSvg] Use QPixmap::mask() instead of deprecated convoluted way via…
Summary

QPixmap::alphaChannel() is deprecated.

Test Plan

Corners of popups still nicely rounded (tested with Oxygen which has much more rounded borders than Breeze)
Also saves half a millisecond on startup, creates 7 masks for me.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 30 2017, 9:46 AM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptAug 30 2017, 9:46 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 30 2017, 10:04 AM
This revision is now accepted and ready to land.Aug 30 2017, 10:04 AM
Closed by commit R242:5921b2a70ced: [FrameSvg] Use QPixmap::mask() instead of deprecated convoluted way via… (authored by broulik). · Explain WhyAug 30 2017, 10:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasma/framesvg.cpp (2 lines)

Diff 18956

View Options

src/plasma/framesvg.cpp

Loading...