Differential D7587

kfileaudiopreview: don't autoplay media files by default
ClosedPublic
Actions

Authored by elvisangelaccio on Aug 28 2017, 3:53 PM.

Details

Reviewers
bshah
Group Reviewers
Plasma
Commits
R320:c1a7f07d4629: kfileaudiopreview: don't autoplay media files by default
Summary

Not only it's annoying, but it's also a potential security risk (basically, a variant of [1]).

[1]: https://scarybeastsecurity.blogspot.com/2016/11/0day-poc-risky-design-decisions-in.html

Test Plan

No longer plays media files when hovering them in the file picker.

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 28 2017, 3:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin added a subscriber: graesslin.Aug 28 2017, 7:33 PM

obviously +1 from me, but as I'm biased towards security I want someone else to accept it

broulik added a subscriber: broulik.Aug 29 2017, 8:28 AM

+1 from me also

bshah accepted this revision.Aug 29 2017, 8:31 AM
This revision is now accepted and ready to land.Aug 29 2017, 8:31 AM
Closed by commit R320:c1a7f07d4629: kfileaudiopreview: don't autoplay media files by default (authored by elvisangelaccio). · Explain WhyAug 29 2017, 3:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18929

View Options

kfileaudiopreview/kfileaudiopreview.cpp

Loading...