[KUrlNavigator] Emit tabRequested when path in path selector menu is middle-clicked
ClosedPublic
Actions

Authored by broulik on Aug 25 2017, 9:11 AM.

Details

Reviewers

kde-frameworks-devel
dfaure

Commits

Summary

The breadcrumbs and menu items in the breadcrumb separators already did that but the path selector, which looks like a breadcrumb separator, did not.

Test Plan

I think this should be the last missing middle click tab handling in the address bar :)

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

Maybe it would be safer/simpler to use a different QObject for watching the menus.

src/filewidgets/kurlnavigator.cpp
371	Warning, that eventFilter method didn't expect to get events for the menu... see below.
1202	This code will now trigger when the menu loses focus. Won't that have unintended side effects?
1207	This code will now trigger when the menu loses focus. Won't that have unintended side effects?

dfaure requested changes to this revision.Sep 3 2017, 9:06 AM

This revision now requires changes to proceed.Sep 3 2017, 9:06 AM

broulik planned changes to this revision.Feb 15 2018, 12:49 PM

(even better would be to unittest this).

This revision is now accepted and ready to land.Apr 28 2018, 10:08 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		src/filewidgets/CMakeLists.txt (1 line)
M		src/filewidgets/kurlnavigator.cpp (6 lines)
A	M	src/filewidgets/kurlnavigatorpathselectoreventfilter.cpp (62 lines)
A	M	src/filewidgets/kurlnavigatorpathselectoreventfilter_p.h (44 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18730			Aug 25 2017, 9:08 AM	★	★
Diff 2	33076			Apr 25 2018, 2:47 PM	★	★
Diff 3	34288	e24affa	R241:fc6b85b832c7c98a9a96d4c35d09ba68533787f4	May 16 2018, 11:46 AM	★	★