kconfig: kcfg.xsd do not require a kcfgfile
ClosedPublic

Authored by winterz on Aug 19 2017, 3:00 PM.

Details

Summary

I'm seeing quite a few kconfigxt files that don't set the kcfgfile element.
This patch changes the xsd so such files will validate.

now you can have 0 or 1 setting of kcfgfile in a .kcfg file and it will still validate

Test Plan

running xmllint against a bunch of .kcfgfiles, some with a kcfgfile element and some without

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
winterz created this revision.Aug 19 2017, 3:00 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 19 2017, 3:00 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
winterz abandoned this revision.Aug 19 2017, 3:13 PM

not good. ignore.

winterz reclaimed this revision.Aug 19 2017, 3:23 PM

un-abandon. I retested and it does work as intended

comments? thoughts?

ping.
this is still relevant.
some kconfigxt files don't set the kcfgfile element.

to name a few:
mailcommon/src/settings/mailcommon.kcfg
kdepim-runtime/agents/newmailnotifier/newmailnotifieragentsettings.kcfg
pim-data-exporter/gui/settings/pimsettingexporterglobalconfig.kcfg
grantlee-editor/grantleethemeeditor/settings/grantleethemeeditor.kcfg
libksieve/src/ksieveui/settings/sieve-editor.kcfg.cmake
knotes/src/settings/knotesglobalconfig.kcfg.cmake
messagelib/messagelist/src/core/settings.kcfg
messagelib/messageviewer/src/messageviewerheaderplugins/defaultgrantleeheaderstyleplugin/settings/defaultgrantleeheaderstyleplugin.kcfg
libgravatar/src/settings/gravatar.kcfg
pim-sieve-editor/src/settings/sieveeditorglobalconfig.kcfg
kmail/agents/archivemailagent/settings/archivemailagentsettings.kcfg

dfaure accepted this revision.May 6 2018, 10:03 PM
dfaure added a subscriber: dfaure.

It helps if you actually add reviewers...

This revision is now accepted and ready to land.May 6 2018, 10:03 PM
This revision was automatically updated to reflect the committed changes.