Show UI for per screen scaling options on supported platforms

Authored by davidedmundson on Aug 15 2017, 3:25 PM.



X still has a global set scale UI
Wayland gets a more normal looking per-screen UI

Test Plan

Diff Detail

R104 KScreen
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Aug 15 2017, 3:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 15 2017, 3:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added inline comments.

Use QComboBox::activated which only fires when the user explicitly selects an option, should also remove the need for blocking signals above.

Probably would be better, I was just copying the current code.
I'll fix the rest of the KCM, and update this.

sebas added a subscriber: sebas.Aug 15 2017, 3:49 PM

This UI change should be addressed with the new KScreen KCM, btw.

Kai's comments

sebas accepted this revision.Aug 15 2017, 4:01 PM

Nice! :)


nullptr; ?

The previous code didn't do this, but I think it's because it wasn't allowed in the C++ it was written in originally. I prefer to have these things initialized to nullptrs, mainly because I'm an idiot and want to make my own life easier. :)


nullptr; please

This revision is now accepted and ready to land.Aug 15 2017, 4:01 PM
This revision was automatically updated to reflect the committed changes.