Differential D7316

Avoid sending data offers from an invalid source.
ClosedPublic
Actions

Authored by davidedmundson on Aug 14 2017, 11:47 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R127:1b2794985361: Avoid sending data offers from an invalid source.
Summary

A DataDevice will have a source when offers are available, but it can
also be legitimately cleared.

When calling DataDeviceInterface::sendSelection(DataDeviceInterface
*other) if the other data device has no source, we should be setting
that we also have no source.

In addition this also guards against Seat tracking a DataDeviceInterface
with no source when trying to sync x clipboards.

BUG: 383054

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added projects: Plasma on Wayland, Frameworks. · View Herald TranscriptAug 14 2017, 11:47 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
graesslin added a subscriber: graesslin.Aug 15 2017, 4:49 PM
graesslin added inline comments.
src/server/datadevice_interface.cpp
206

please use a dedicated line for the return here.

davidedmundson updated this revision to Diff 18213.Aug 15 2017, 11:17 PM

Split into two lines

Restricted Application edited projects, added Plasma; removed Plasma on Wayland. · View Herald TranscriptAug 15 2017, 11:17 PM
davidedmundson marked an inline comment as done.Aug 15 2017, 11:17 PM
graesslin accepted this revision.Aug 16 2017, 4:00 PM

Nevertheless I still think we should also ship my review. Rather a null check too many than too few.

This revision is now accepted and ready to land.Aug 16 2017, 4:00 PM
Closed by commit R127:1b2794985361: Avoid sending data offers from an invalid source. (authored by davidedmundson). · Explain WhyAug 17 2017, 3:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18293

View Options

autotests/client/test_wayland_seat.cpp

Loading...
View Options

src/server/datadevice_interface.cpp

Loading...