Differential D7281

KCoreAddons: Enforce hidden symbol visibility in nested private classes
ClosedPublic
Actions

Authored by mpyne on Aug 12 2017, 11:41 PM.

Details

Reviewers

kossebau

Group Reviewers

Frameworks

Commits

R244:eb5f8570f4aa: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

Summary

Inspired by D7279, manually declare nested Private classes to have hidden visibility (by default, they inherit the visibility of the class that they are nested under).

This removes the private symbols from the resulting .so (I've verified this myself) although it's only a micro-optimization with regard to binary size.

Test Plan

All autotests continue to pass, no additional build warnings.

Diff Detail

Repository

R244 KCoreAddons

Lint

Lint Skipped

Unit

Unit Tests Skipped

mpyne created this revision.Aug 12 2017, 11:41 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptAug 12 2017, 11:41 PM

@mpyne: Beware, I have such patches prepared for all of KF :)

In D7281#135053, @kossebau wrote:

@mpyne: Beware, I have such patches prepared for all of KF :)

OK, I'll hold off on this one pending your KF5-wide patchset ;)

kossebau accepted this revision.Aug 15 2017, 1:29 AM

This revision is now accepted and ready to land.Aug 15 2017, 1:29 AM

Hm, I tried to close this one by adding a line
Differential Revision: https://phabricator.kde.org/D7281
in the commit, but seems that was not picked up, so closing manually
See eb5f8570f4aa3f6391ef0c040f55b1331e36e0c7

I'm not sure why that happened - it automatically associated correctly so it should have closed.

It does appear that one of the reviews (Frameworks) hasn't approved it yet so that may be the reason why.
(Phabricator upstream are big on stuff not going in without proper review)

Revision Contents
Changeset List

			Path	Packages
M			src/lib/caching/kshareddatacache.cpp (2 lines)
M			src/lib/caching/kshareddatacache_win.cpp (2 lines)
M			src/lib/jobs/kjobtrackerinterface.cpp (2 lines)
M			src/lib/jobs/kjobuidelegate.cpp (2 lines)
M			src/lib/kaboutdata.cpp (6 lines)
M			src/lib/randomness/krandomsequence.cpp (2 lines)
M			src/lib/util/kdelibs4configmigrator.cpp (2 lines)
M			src/lib/util/kuser_unix.cpp (4 lines)
M			src/lib/util/kuser_win.cpp (4 lines)