Set the QtQuick Controls 1 style name explicitly
ClosedPublic

Authored by fvogt on Aug 11 2017, 7:18 PM.

Details

Summary

It does explicitly what the comment above the export implies.
That way this warning on every use of Quick Controls 1 is gone:

WARNING: Cannot find style "org.kde.desktop" - fallback: "/usr/lib64/qt5/qml/QtQuick/Controls/Styles/Desktop"

Note that I'm not 100% sure that this does not have any
ill side effects as I don't quite understand what and where
org.kde.desktop is supposed to be.

Test Plan

Started plasmashell and plasma-discover both with and without
the change, no difference except that the warning is now gone.

Diff Detail

Repository
R120 Plasma Workspace
Branch
warnfix
Lint
No Linters Available
Unit
No Unit Test Coverage
fvogt created this revision.Aug 11 2017, 7:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 11 2017, 7:18 PM
mart accepted this revision.Aug 14 2017, 9:52 AM
mart added a subscriber: mart.

thanks for looking into that

This revision is now accepted and ready to land.Aug 14 2017, 9:52 AM
This revision was automatically updated to reflect the committed changes.

Is this a result of this change?

Seems it is.

Unsetting that env var and restarting plasmashell makes it go away.

Reversing that again make the ugliness shown there come back.

fvogt added a comment.Aug 15 2017, 5:13 PM

openQA found something that looks related as well, but unsetting does not help: https://openqa.opensuse.org/tests/467477#step/systemsettings5/5

I cannot reproduce the issue you have either.
Maybe some kind of cache or leftovers from other styles? This change should really be a no-op.

I am seeing this in both Neon dev-unstable edition (Xenial base), and Kubuntu's CI packages (Artful base). Another user is also seeing it in the Kubuntu CI builds.

In both I have created a new user and tested under that, which should eliminate any caching issues. The result is the same and the issue persists.

fvogt added a comment.Aug 15 2017, 6:08 PM

Does it work with export QT_QUICK_CONTROLS_1_STYLE=Breeze?

I don't know how the style selection of Quick Controls work, maybe someone more knowledgeable in that area could chime in here.

In D7257#136069, @fvogt wrote:

Does it work with export QT_QUICK_CONTROLS_1_STYLE=Breeze?

I don't know how the style selection of Quick Controls work, maybe someone more knowledgeable in that area could chime in here.

Yes, that seems to work ok.

Again, reverting to '=Desktop' results in the issue reoccurring.

rikmills added a comment.EditedAug 15 2017, 6:21 PM

I don't think it has an effect here, but for completeness just in case, I should mention that both Neon and Kubuntu have a patch to #startkde/startkde.cmake

https://packaging.neon.kde.org/plasma/plasma-workspace.git/tree/debian/patches/kubuntu_startkde-qtpath.diff?h=Neon/unstable

though I could be mistaken, so would not like to leave that fact out of the discussion.