Differential D7249

Return high-resolution line edit clear icon
ClosedPublic
Actions

Authored by broulik on Aug 11 2017, 11:34 AM.

Details

Reviewers
kde-frameworks-devel
hpereiradacosta
davidedmundson
Commits
R252:588cd0075612: Return high-resolution line edit clear icon
Summary

Qt just returns a 16px pixmap by default leading to blurry results when larger icon sizes for small icons are configured by the user.

Test Plan

Originally posted as https://git.reviewboard.kde.org/r/128895

I'm still seeing the issue without this patch.

@hpereiradacosta In Dolphin press Ctrl+F to enter the search, the KUrlComboBox in the address bar does *not* exhibit this bug as KLineEdit does not use QLineEdit's action feature but its own KLineEditButton

Diff Detail

Repository
R252 Framework Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 11 2017, 11:34 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 11 2017, 11:34 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
hpereiradacosta edited edge metadata.Aug 15 2017, 7:40 AM

+1 from me. Sounds sensible.

davidedmundson accepted this revision.Aug 15 2017, 11:39 AM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
src/kstyle/kstyle.cpp
419

just QIcon::fromTheme(directionalThemeName, "edit-clear")

This revision is now accepted and ready to land.Aug 15 2017, 11:39 AM
broulik added inline comments.Aug 15 2017, 12:51 PM
src/kstyle/kstyle.cpp
419

You mean QIcon::fromTheme(directionalThemeName, QIcon::fromTheme("edit-clear"));?

Closed by commit R252:588cd0075612: Return high-resolution line edit clear icon (authored by broulik). · Explain WhyAug 25 2017, 2:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kstyle/kstyle.cpp (8 lines)

Diff 18757

View Options

src/kstyle/kstyle.cpp

Loading...