Differential D7157

Add copy button in AbstractNavigationWidget
ClosedPublic
Actions

Authored by patrickelectric on Aug 6 2017, 12:58 AM.

Details

Reviewers
kfunk
brauch
Group Reviewers
KDevelop
Commits
R33:dadaf13191e5: Add copy button in AbstractNavigationWidget
R32:dadaf13191e5: Add copy button in AbstractNavigationWidget
Summary

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptAug 6 2017, 12:58 AM
brauch added a subscriber: brauch.Aug 6 2017, 6:33 AM

Hmm, sorry, I don't like this. I think it adds a lot of visual clutter for something most people never want to do ever ...
The copy-on-select feature is great, but the button is overkill.

patrickelectric updated this revision to Diff 17783.Aug 6 2017, 5:04 PM

Remove button, change commit message

kfunk accepted this revision.Aug 7 2017, 7:44 AM
kfunk added a subscriber: kfunk.

Okay, I don't care too much. So +1.

In D5794 I was against this exact change, merely b/c it's probably not really discoverable this way. But agreed, a button is overkill, too.

This revision is now accepted and ready to land.Aug 7 2017, 7:44 AM
brauch requested changes to this revision.Aug 7 2017, 8:17 AM

see inline, otherwise lgtm

language/duchain/navigation/abstractnavigationwidget.cpp
114 ↗(On Diff #17783)

don't use [=], use [this].

This revision now requires changes to proceed.Aug 7 2017, 8:17 AM
Closed by commit R33:dadaf13191e5: Add copy button in AbstractNavigationWidget (authored by patrickelectric, committed by kfunk). · Explain WhyAug 7 2017, 6:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 17849

View Options

language/duchain/navigation/abstractnavigationwidget.cpp

Loading...