Differential D7007

patch for Bug 362626 - Color to Alpha - Create filter mask issue
ClosedPublic
Actions

Authored by shreyasr on Jul 30 2017, 7:25 PM.

Details

Reviewers
rempt
dkazakov
Test Plan

tested by building and running

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
shreyasr created this revision.Jul 30 2017, 7:25 PM
Restricted Application added a subscriber: woltherav. · View Herald TranscriptJul 30 2017, 7:25 PM
dkazakov requested changes to this revision.Aug 2 2017, 11:12 AM

Hi, @shreyasr!

The problem happens because when the new mask is added to the image, the filter is applied again on that mask. I don't know why it happens (most probably, KisFilterManager is connected to some activeNodeChanged() signal, and it triggers restart of the preview). This behavior should be fixed by not allowing the dialog to restart the preview stroke, but not by just applying it and then undoing again :(

This revision now requires changes to proceed.Aug 2 2017, 11:12 AM
shreyasr updated this revision to Diff 17768.Aug 6 2017, 8:46 AM
shreyasr edited edge metadata.
shreyasr edited the summary of this revision. (Show Details)
dkazakov added a comment.Aug 7 2017, 9:16 AM

Hi, @shreyasr!

Could you check if the patch still works if Preview checkbox is disabled? As far as I remember, the purpose of this 'if' was to apply the filter if the preview was disabled.

shreyasr added a comment.Aug 7 2017, 10:49 AM

Its working fine even with preview disabled

dkazakov requested changes to this revision.Aug 7 2017, 4:03 PM

I just tested. It doesn't apply the filter if the the Preview checkbox was disabled during the previous application of the filter. See the attached video:

krita_filter_bug.mkv724 KBDownload

This revision now requires changes to proceed.Aug 7 2017, 4:03 PM
shreyasr updated this revision to Diff 17927.Aug 9 2017, 1:43 PM
shreyasr edited edge metadata.
dkazakov accepted this revision.Aug 15 2017, 6:20 AM

Hi, @shreyasr!

The patch works perfectly fine now, please push! :)

This revision is now accepted and ready to land.Aug 15 2017, 6:20 AM
dkazakov closed this revision.Apr 18 2018, 10:16 AM

The patch has been pushed by the author in e2813cef9b71c9b5553551a88cf4409274e17d75 :)

Revision Contents
Changeset List

PathPackages
Mlibs/ui/dialogs/kis_dlg_filter.cpp (4 lines)

Diff 17768

View Options

libs/ui/dialogs/kis_dlg_filter.cpp

Loading...