Differential D6936

ECMGeneratePriFile - mac os x framework builds of Qt
AbandonedPublic
Actions

Authored by winterz on Jul 26 2017, 3:28 PM.

Details

Reviewers
dfaure
Summary

on mac os x framework builds of Qt, QT/include is not added to the list of include path,. this patch looks up one level so those includes can be found

Test Plan

used the generated pri file on Mac

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Lint Skipped
Unit
Unit Tests Skipped
winterz created this revision.Jul 26 2017, 3:28 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptJul 26 2017, 3:28 PM
Restricted Application added subscribers: Build System, Frameworks. · View Herald Transcript
dfaure edited edge metadata.Jul 26 2017, 3:37 PM

This would make a large number of other headers accessible on other Unixes.

So this additional include should be added only on Mac OS.

I'm also a bit confused by the description. You say "QT/include" but this is rather about the includes for the framework, no?

winterz abandoned this revision.Jul 26 2017, 6:43 PM

Revision Contents
Changeset List

PathPackages
Mmodules/ECMGeneratePriFile.cmake (2 lines)

Diff 17239

View Options

modules/ECMGeneratePriFile.cmake

Loading...