Differential D6935

Don't expand Tabs
AbandonedPublic
Actions

Authored by romangg on Jul 26 2017, 3:23 PM.

Details

Reviewers
ngraham
Group Reviewers
Konsole
Summary

Since Qt 5.9 tabs expand always. Set it explicitly to not do. In the past the tabs had a fixed size and now they adapt to the text length. But still better than fully expanded ones:

Bug: https://bugs.kde.org/show_bug.cgi?id=380879

Diff Detail

Repository
R319 Konsole
Lint
Lint Skipped
Unit
Unit Tests Skipped
romangg created this revision.Jul 26 2017, 3:23 PM
hindenburg added a subscriber: hindenburg.Jul 27 2017, 1:56 PM

Don't we want to only do this for Qt5.9.* ?

romangg added a comment.Jul 28 2017, 9:00 AM
In D6935#129512, @hindenburg wrote:

Don't we want to only do this for Qt5.9.* ?

The property should be available on 5.7 as well. Where can I look this up? If it is, I would say we don't make a distinction and have the same visuals after the patch on 5.9 and 5.7. If fixed size is better or not is subjective any way.

hindenburg added a comment.Jul 28 2017, 12:37 PM

I mean the "bug" is only on 5.9 so let's leave <5.9 as is

ngraham requested changes to this revision.Oct 23 2017, 12:08 AM
ngraham added a subscriber: ngraham.
  1. To check for QT version, you could do this:
#if QT_VERSION >= QT_VERSION_CHECK(5, 9, 0)
setExpanding(false);
#endif
  1. Please change "Bug: https://bugs.kde.org/show_bug.cgi?id=380879" to "BUG: 380879" to trigger the appropriate macro and get that bug closed automatically when this goes in.
This revision now requires changes to proceed.Oct 23 2017, 12:08 AM
romangg abandoned this revision.Oct 23 2017, 3:06 PM

Abandoning since maintainer doesn't like non expanding tabs.

Revision Contents
Changeset List

PathPackages
Msrc/ViewContainerTabBar.cpp (1 line)

Diff 17238

View Options

src/ViewContainerTabBar.cpp

Loading...