Details
Details
- Reviewers
dkazakov scottpetrovic - Group Reviewers
Krita - Commits
- R37:dcb9b60f6109: Option to control cursor color and grid color/threshold/color
Diff Detail
Diff Detail
- Repository
- R37 Krita
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
thanks for the patch @lieroz !
It functionally seems to be working pretty well. I do have a few suggestions that should be pretty simple to update to help make it more organized.
- We already have an area for cursor options, so that would probably be better there. ( Configure Krita > General > Cursor tab)
- We already have a grid, so maybe we should call it something more descriptive like "Pixel Grid". Update any references you have (including variable names).
- "Threshold" label name -- maybe call this "Start showing at " (this is a bit subjective, but I think is easier to understand)
Other than that looks great on my end.
Comment Actions
Hi, @lieroz!
I would suggest two updates for the pixel grid settings:
- Remove extra checkbox and make the whole groupbox checkable, like the "OpenGL" group
- When the group is unchecked, disable the group and all its controls
Comment Actions
The patch works perfectly fine now!
@scottpetrovic, do you have any comments about it?
Comment Actions
No, I don't have access to make my own commits. Dmitriy will do it instead from my name. :)