lieroz (Andrey Kamakin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jun 27 2017, 2:40 PM (76 w, 4 d)
Availability
Available

Recent Activity

Sep 15 2018

lieroz committed R37:a879aa510795: Fixed potential race in getTileLazy. (authored by lieroz).
Fixed potential race in getTileLazy.
Sep 15 2018, 1:16 PM
lieroz requested review of D15533: Fix race condition on getTileLazy.
Sep 15 2018, 12:23 PM · Krita

Aug 14 2018

lieroz closed T5519: Move tool needs optimizations as Resolved.
Aug 14 2018, 1:11 PM · Krita: Stable bug fixes
lieroz closed T9130: Lock fixing in Krita's tile manager. as Resolved.
Aug 14 2018, 1:11 PM · Krita
lieroz closed T9130: Lock fixing in Krita's tile manager., a subtask of T8628: Optimize multithreading in Krita's Tile Manager, as Resolved.
Aug 14 2018, 1:11 PM · Krita
lieroz closed T8874: Port lock free map into Krita instead of KisTileHashTableTraits. as Resolved.
Aug 14 2018, 1:11 PM · Krita
lieroz closed T8874: Port lock free map into Krita instead of KisTileHashTableTraits. , a subtask of T8628: Optimize multithreading in Krita's Tile Manager, as Resolved.
Aug 14 2018, 1:11 PM · Krita
lieroz added a comment to T8628: Optimize multithreading in Krita's Tile Manager.

Aug 14 2018, 9:40 AM · Krita

Aug 12 2018

lieroz committed R37:eb073effe958: Fixed invalid history tiles due to getTileLazy implementation in lock free hash… (authored by lieroz).
Fixed invalid history tiles due to getTileLazy implementation in lock free hash…
Aug 12 2018, 5:55 PM
lieroz added a commit to T8874: Port lock free map into Krita instead of KisTileHashTableTraits. : R37:eb073effe958: Fixed invalid history tiles due to getTileLazy implementation in lock free hash….
Aug 12 2018, 5:55 PM · Krita

Aug 11 2018

lieroz added a comment to T8628: Optimize multithreading in Krita's Tile Manager.

Here are some drafts on performance gain during different coding period:
My PC (2 cores 4 threads): https://docs.google.com/spreadsheets/d/1744goPIfc51j49Nlm8othm2599ozOAYEICV64wabKYk/edit#gid=0
Black monster (10 cores 20 threads): https://docs.google.com/spreadsheets/d/1lmrh37o_nPkRjFCjCEaqyuX0UyIhNC3VxIjMvhmK1c4/edit#gid=0

Aug 11 2018, 6:28 PM · Krita
lieroz added a comment to T8628: Optimize multithreading in Krita's Tile Manager.

Current project state: I guess that project is done by 2/3. I managed to add lock free hash table to fix thread waiting on blocking one, there are still some bugs there that I'm currently trying to fix. That was the first part. Then there were 3 locks in KisTiledDataManager class, they also were fixed and tested. The last one is associated with scheduling jobs, there are 4 hotspots that had to be fixed, I managed to get rid of 2 of them, but last 2 are quite deeply connected with scheduling algorithm. I tried making classes lock free and introduce RW locks, but it was a week of segfauls and errors... There is some work on that, but last 2 spots are really tough, maybe they must be fixed on higher level by introducing new interfaces.

Aug 11 2018, 6:04 PM · Krita

Aug 9 2018

lieroz committed R37:b7e7442e946f: Fixed KisKraSaverTest (authored by lieroz).
Fixed KisKraSaverTest
Aug 9 2018, 12:43 PM
lieroz added a commit to T8874: Port lock free map into Krita instead of KisTileHashTableTraits. : R37:b7e7442e946f: Fixed KisKraSaverTest.
Aug 9 2018, 12:43 PM · Krita
lieroz committed R37:572b2ad2868b: Fixed errors due to invalid cpy constructor in lock free table. (authored by lieroz).
Fixed errors due to invalid cpy constructor in lock free table.
Aug 9 2018, 11:45 AM
lieroz added a commit to T8874: Port lock free map into Krita instead of KisTileHashTableTraits. : R37:572b2ad2868b: Fixed errors due to invalid cpy constructor in lock free table..
Aug 9 2018, 11:45 AM · Krita

Aug 8 2018

lieroz committed R37:4a73d504781b: Made wrapper around qlist to make it thread safe. (authored by lieroz).
Made wrapper around qlist to make it thread safe.
Aug 8 2018, 11:02 AM
lieroz added a commit to T9268: Krita's work scheduler internal lock fixes: R37:4a73d504781b: Made wrapper around qlist to make it thread safe..
Aug 8 2018, 11:02 AM · Krita

Aug 7 2018

lieroz committed R37:8b1e45185e98: Resolved merge conflicts. (authored by lieroz).
Resolved merge conflicts.
Aug 7 2018, 7:32 PM
lieroz added a commit to T9268: Krita's work scheduler internal lock fixes: R37:8b1e45185e98: Resolved merge conflicts..
Aug 7 2018, 7:32 PM · Krita
lieroz committed R37:7d39292232e2: Merge branch 'master' into akamakin/T9268-scheduler-optimization (authored by lieroz).
Merge branch 'master' into akamakin/T9268-scheduler-optimization
Aug 7 2018, 7:17 PM
lieroz committed R37:caa4245ff49d: Merge branch 'akamakin/tile-manager-bug-fixes' (authored by lieroz).
Merge branch 'akamakin/tile-manager-bug-fixes'
Aug 7 2018, 4:21 PM
lieroz added a comment to D14660: Krita's work scheduler internal lock fixes.

Thanks. No it doesn't, maybe 1% better, no more, cause threads just wait on other places.

Aug 7 2018, 4:11 PM · Krita
lieroz committed R37:aa5df33c8095: Changed updater context logic to avoid deadlocks. (authored by lieroz).
Changed updater context logic to avoid deadlocks.
Aug 7 2018, 9:14 AM
lieroz added a commit to T9268: Krita's work scheduler internal lock fixes: R37:aa5df33c8095: Changed updater context logic to avoid deadlocks..
Aug 7 2018, 9:14 AM · Krita
lieroz committed R37:f485c81c1e48: Merge branch 'master' into akamakin/T9268-scheduler-optimization (authored by lieroz).
Merge branch 'master' into akamakin/T9268-scheduler-optimization
Aug 7 2018, 9:14 AM

Aug 6 2018

lieroz committed R37:5311b66754f2: Changed signals for function calls. (authored by lieroz).
Changed signals for function calls.
Aug 6 2018, 6:13 PM
lieroz requested review of D14660: Krita's work scheduler internal lock fixes.
Aug 6 2018, 6:09 PM · Krita
lieroz committed R37:1c4b3614fcae: Removed commented ou code and changed write locks for mutexes. (authored by lieroz).
Removed commented ou code and changed write locks for mutexes.
Aug 6 2018, 5:03 PM
lieroz added a commit to T9268: Krita's work scheduler internal lock fixes: R37:1c4b3614fcae: Removed commented ou code and changed write locks for mutexes..
Aug 6 2018, 5:03 PM · Krita
lieroz committed R37:a33257db254f: Commented out batch update jobs execution. (authored by lieroz).
Commented out batch update jobs execution.
Aug 6 2018, 11:18 AM
lieroz added a commit to T9268: Krita's work scheduler internal lock fixes: R37:a33257db254f: Commented out batch update jobs execution..
Aug 6 2018, 11:18 AM · Krita

Aug 5 2018

lieroz committed R37:9dd6306c9b81: Changed qt signals for simple function calls in crutchy way. (authored by lieroz).
Changed qt signals for simple function calls in crutchy way.
Aug 5 2018, 7:49 PM
lieroz added a commit to T9268: Krita's work scheduler internal lock fixes: R37:9dd6306c9b81: Changed qt signals for simple function calls in crutchy way..
Aug 5 2018, 7:48 PM · Krita
lieroz committed R37:898614eea0c1: Hacky optimizations. (authored by lieroz).
Hacky optimizations.
Aug 5 2018, 7:04 PM
lieroz added a commit to T9268: Krita's work scheduler internal lock fixes: R37:898614eea0c1: Hacky optimizations..
Aug 5 2018, 7:04 PM · Krita

Aug 2 2018

lieroz committed R37:4203bcc5988e: Removed mutex comments from kis layer. (authored by lieroz).
Removed mutex comments from kis layer.
Aug 2 2018, 11:15 AM
lieroz added a commit to T9268: Krita's work scheduler internal lock fixes: R37:4203bcc5988e: Removed mutex comments from kis layer..
Aug 2 2018, 11:15 AM · Krita
lieroz committed R37:5e2601e20233: Changed mutex in KisSimpleUpdateQueue for rw lock. (authored by lieroz).
Changed mutex in KisSimpleUpdateQueue for rw lock.
Aug 2 2018, 10:47 AM
lieroz added a commit to T9268: Krita's work scheduler internal lock fixes: R37:5e2601e20233: Changed mutex in KisSimpleUpdateQueue for rw lock..
Aug 2 2018, 10:47 AM · Krita
lieroz committed R37:44148bc7e1bf: Merge branch 'master' into akamakin/T9268-scheduler-optimization (authored by lieroz).
Merge branch 'master' into akamakin/T9268-scheduler-optimization
Aug 2 2018, 10:47 AM

Aug 1 2018

lieroz committed R37:941b74b59700: Removed crutchy rw locks. (authored by lieroz).
Removed crutchy rw locks.
Aug 1 2018, 6:43 PM
lieroz added a commit to T9268: Krita's work scheduler internal lock fixes: R37:941b74b59700: Removed crutchy rw locks..
Aug 1 2018, 6:43 PM · Krita
lieroz committed R37:63cc54768fcb: Merge branch 'master' into akamakin/T9268-scheduler-optimization (authored by lieroz).
Merge branch 'master' into akamakin/T9268-scheduler-optimization
Aug 1 2018, 6:43 PM
lieroz committed R37:a9a48431bfc7: Merge branch 'master' into akamakin/T9268-scheduler-optimization (authored by lieroz).
Merge branch 'master' into akamakin/T9268-scheduler-optimization
Aug 1 2018, 11:42 AM

Jul 31 2018

lieroz committed R37:5dae4bec18ab: Merge branch 'master' into akamakin/T9268-scheduler-optimization (authored by lieroz).
Merge branch 'master' into akamakin/T9268-scheduler-optimization
Jul 31 2018, 6:08 PM
lieroz committed R37:4d0ecd5f9990: Merge branch 'master' of git://anongit.kde.org/krita (authored by lieroz).
Merge branch 'master' of git://anongit.kde.org/krita
Jul 31 2018, 6:01 PM
lieroz committed R37:10996d6fa5bd: Fixed kis_tiled_data_manager_test. (authored by lieroz).
Fixed kis_tiled_data_manager_test.
Jul 31 2018, 6:01 PM
lieroz committed R37:df20641705b4: Merge branch 'akamakin/tile-manager-bug-fixes' (authored by lieroz).
Merge branch 'akamakin/tile-manager-bug-fixes'
Jul 31 2018, 12:02 PM
lieroz committed R37:5b220a44fd5e: Fixed problems with invalid extent. (authored by lieroz).
Fixed problems with invalid extent.
Jul 31 2018, 11:43 AM
lieroz added a commit to T9130: Lock fixing in Krita's tile manager.: R37:5b220a44fd5e: Fixed problems with invalid extent..
Jul 31 2018, 11:43 AM · Krita

Jul 30 2018

lieroz committed R37:762a9a647942: Merge branch 'akamakin/tile-manager-bug-fixes' (authored by lieroz).
Merge branch 'akamakin/tile-manager-bug-fixes'
Jul 30 2018, 4:11 PM
lieroz committed R37:858dd2c6b471: Fixed low memory tests. (authored by lieroz).
Fixed low memory tests.
Jul 30 2018, 4:11 PM
lieroz added a commit to T8874: Port lock free map into Krita instead of KisTileHashTableTraits. : R37:858dd2c6b471: Fixed low memory tests..
Jul 30 2018, 4:11 PM · Krita

Jul 29 2018

lieroz committed R37:4d9161fabf72: Fixed tests. (authored by lieroz).
Fixed tests.
Jul 29 2018, 6:14 PM
lieroz added a commit to T8874: Port lock free map into Krita instead of KisTileHashTableTraits. : R37:4d9161fabf72: Fixed tests..
Jul 29 2018, 6:14 PM · Krita

Jul 27 2018

lieroz committed R37:0313fa87b987: Added batch update jobs. (authored by lieroz).
Added batch update jobs.
Jul 27 2018, 9:22 AM
lieroz added a commit to T9268: Krita's work scheduler internal lock fixes: R37:0313fa87b987: Added batch update jobs..
Jul 27 2018, 9:22 AM · Krita

Jul 25 2018

lieroz committed R37:d8be38cea9cd: Removed thread waiting on rw lock. (authored by lieroz).
Removed thread waiting on rw lock.
Jul 25 2018, 6:22 PM
lieroz added a commit to T9268: Krita's work scheduler internal lock fixes: R37:d8be38cea9cd: Removed thread waiting on rw lock..
Jul 25 2018, 6:22 PM · Krita
lieroz committed R37:7cdf70eb3767: Added first attempts to get rid of waiting on locks. (authored by lieroz).
Added first attempts to get rid of waiting on locks.
Jul 25 2018, 1:05 PM
lieroz added a commit to T9268: Krita's work scheduler internal lock fixes: R37:7cdf70eb3767: Added first attempts to get rid of waiting on locks..
Jul 25 2018, 1:05 PM · Krita

Jul 24 2018

lieroz moved T9268: Krita's work scheduler internal lock fixes from Backlog to Google Summer of Code 2018 on the Krita board.
Jul 24 2018, 6:31 PM · Krita
lieroz added a comment to T9268: Krita's work scheduler internal lock fixes.
Jul 24 2018, 5:31 PM · Krita
lieroz created T9268: Krita's work scheduler internal lock fixes.
Jul 24 2018, 5:30 PM · Krita
lieroz committed R37:787e3b8fbe82: Merge remote-tracking branch 'origin/master' into akamakin/tile-manager-bug… (authored by lieroz).
Merge remote-tracking branch 'origin/master' into akamakin/tile-manager-bug…
Jul 24 2018, 5:09 PM
lieroz committed R37:2ae46de8acb2: Changed extent manager migration logic for more straight forward one. (authored by lieroz).
Changed extent manager migration logic for more straight forward one.
Jul 24 2018, 1:46 PM
lieroz added a commit to T9130: Lock fixing in Krita's tile manager.: R37:2ae46de8acb2: Changed extent manager migration logic for more straight forward one..
Jul 24 2018, 1:46 PM · Krita

Jul 20 2018

lieroz added a parent task for T9130: Lock fixing in Krita's tile manager.: T8628: Optimize multithreading in Krita's Tile Manager.
Jul 20 2018, 6:19 PM · Krita
lieroz added a subtask for T8628: Optimize multithreading in Krita's Tile Manager: T9130: Lock fixing in Krita's tile manager..
Jul 20 2018, 6:19 PM · Krita

Jul 19 2018

lieroz committed R37:44cee340625d: Make the readonly parameter for Kis(Image)Config explicit (authored by rempt).
Make the readonly parameter for Kis(Image)Config explicit
Jul 19 2018, 11:46 AM
lieroz committed R37:c7dd99ee6ffd: Always use the same sipname as PyQt (authored by arojas).
Always use the same sipname as PyQt
Jul 19 2018, 11:22 AM
lieroz committed R37:7fca5f0435e4: Added licenses. (authored by lieroz).
Added licenses.
Jul 19 2018, 11:22 AM
lieroz committed R37:ffed51488dbd: Use Qt's internal error message as custom error message when file export fails… (authored by victorw).
Use Qt's internal error message as custom error message when file export fails…
Jul 19 2018, 11:22 AM
lieroz committed R37:c8dabaef94c0: Use Qt's internal error message as custom error message when file export fails. (authored by victorw).
Use Qt's internal error message as custom error message when file export fails.
Jul 19 2018, 11:22 AM
lieroz committed R37:c3bf575f4bbc: Fix XML (authored by yurchor).
Fix XML
Jul 19 2018, 11:22 AM
lieroz committed R37:86f54464bffd: Improve error message in dialog when saving fails and no custom error message… (authored by victorw).
Improve error message in dialog when saving fails and no custom error message…
Jul 19 2018, 11:22 AM
lieroz committed R37:7c8b81aa104d: Fix PyQt5 check. Broke for version 5.10.1. (authored by victorw).
Fix PyQt5 check. Broke for version 5.10.1.
Jul 19 2018, 11:22 AM
lieroz committed R37:c6b1ec5daeda: Add ${SOURCE}/po/ to .gitignore; ignore external translation files if available (authored by victorw).
Add ${SOURCE}/po/ to .gitignore; ignore external translation files if available
Jul 19 2018, 11:22 AM
lieroz committed R37:4dd25c091b29: Add a link to our how-to-report-a-bug manual (authored by rempt).
Add a link to our how-to-report-a-bug manual
Jul 19 2018, 11:22 AM
lieroz committed R37:6ce7784ae861: Reduce aliasing in reference images (authored by jounip).
Reduce aliasing in reference images
Jul 19 2018, 11:22 AM
lieroz committed R37:f371aa20292b: Try to fix the version string for sip once more (authored by rempt).
Try to fix the version string for sip once more
Jul 19 2018, 11:22 AM
lieroz committed R37:3a1c7110d4d0: Replace i18n() with ki18n() in kis_filter_category_ids.cpp to ensure strings… (authored by victorw).
Replace i18n() with ki18n() in kis_filter_category_ids.cpp to ensure strings…
Jul 19 2018, 11:22 AM
lieroz committed R37:2c644b9985f8: Remove unused FiltersCategoryNonPhotorealisticId (authored by victorw).
Remove unused FiltersCategoryNonPhotorealisticId
Jul 19 2018, 11:22 AM
lieroz committed R37:abef774f0c9f: Extracted filter category KoIDs to a separate file (authored by victorw).
Extracted filter category KoIDs to a separate file
Jul 19 2018, 11:22 AM
lieroz added a commit to T6560: Optimize KoID: R37:abef774f0c9f: Extracted filter category KoIDs to a separate file.
Jul 19 2018, 11:22 AM · Krita
lieroz committed R37:1db347d7a49e: Fix KMainWindow saving incorrect widget settings (authored by rempt).
Fix KMainWindow saving incorrect widget settings
Jul 19 2018, 11:21 AM
lieroz committed R37:b5eab7703bd1: Add #if QT_VERSION >= 0x050900 to the include for QOperatingSystemVersion (authored by rempt).
Add #if QT_VERSION >= 0x050900 to the include for QOperatingSystemVersion
Jul 19 2018, 11:21 AM
lieroz committed R37:7becfcb979cd: Add policy CMP0071: we do not want cmake to mess with autogenerated files (authored by rempt).
Add policy CMP0071: we do not want cmake to mess with autogenerated files
Jul 19 2018, 11:21 AM
lieroz committed R37:d69cbd3cfce0: Improve comment (authored by rempt).
Improve comment
Jul 19 2018, 11:21 AM
lieroz committed R37:5c5fa3f4758e: Get rid of "name" parameter when creating the KoID in KisPaintOpPreset::paintOp… (authored by victorw).
Get rid of "name" parameter when creating the KoID in KisPaintOpPreset::paintOp…
Jul 19 2018, 11:21 AM
lieroz added a commit to T6560: Optimize KoID: R37:5c5fa3f4758e: Get rid of "name" parameter when creating the KoID in KisPaintOpPreset::paintOp….
Jul 19 2018, 11:21 AM · Krita
lieroz committed R37:54e98b12b918: A few formatting changes (authored by scottpetrovic).
A few formatting changes
Jul 19 2018, 11:21 AM
lieroz committed R37:e553982beb78: Keep the recent files in sync when re-opening welcome screen (authored by scottpetrovic).
Keep the recent files in sync when re-opening welcome screen
Jul 19 2018, 11:21 AM
lieroz committed R37:8d95135e487c: Fix ordering of recent items on welcome screen (authored by scottpetrovic).
Fix ordering of recent items on welcome screen
Jul 19 2018, 11:21 AM
lieroz committed R37:c69c7f972fa9: Use PyQt5_VERSION_STR (authored by rempt).
Use PyQt5_VERSION_STR
Jul 19 2018, 11:21 AM
lieroz committed R37:952f4dcef080: Move kis_assert.h include in KoColor from header to source as it's no longer… (authored by victorw).
Move kis_assert.h include in KoColor from header to source as it's no longer…
Jul 19 2018, 11:21 AM
lieroz committed R37:5eb99d40138e: Try to fix the version_greater check (authored by rempt).
Try to fix the version_greater check
Jul 19 2018, 11:21 AM
lieroz committed R37:8173f41ff31f: Fix Windows build (authored by rempt).
Fix Windows build
Jul 19 2018, 11:21 AM
lieroz committed R37:3c592ec81cd2: Added initial Qt Designer plugin for Krita widgets KisColorSpaceSelector and… (authored by victorw).
Added initial Qt Designer plugin for Krita widgets KisColorSpaceSelector and…
Jul 19 2018, 11:21 AM