Differential D6732

Display the error message in warning dialog
ClosedPublic
Actions

Authored by madcatx on Jul 16 2017, 1:24 PM.

Details

Reviewers
elvisangelaccio
Commits
R320:18e2236b492c: Display the error message in warning dialog
Summary

Display proper error message in the warning dialog. This is likely to require translation updates.

Diff Detail

Repository
R320 KIO Extras
Lint
Lint Skipped
Unit
Unit Tests Skipped
elvisangelaccio requested changes to this revision.Jul 16 2017, 3:20 PM
elvisangelaccio added inline comments.
smb/kio_smb_browse.cpp
291

Prefer xi18n() with the <nl/> tag rather than \n.

Long explanation in https://api.kde.org/frameworks/ki18n/html/prg_guide.html#kuit_markup if you are interested.

Also, 'stat' is a rather technical word which is not easy to translate. We should probably use another word (open?)

This revision now requires changes to proceed.Jul 16 2017, 3:20 PM
madcatx updated this revision to Diff 16788.Jul 16 2017, 6:38 PM
madcatx edited edge metadata.
  • Use more universal xi18n()
  • Use a less technical description of the error
elvisangelaccio accepted this revision.Jul 17 2017, 5:30 PM

Have you requested a developer account yet?

This revision is now accepted and ready to land.Jul 17 2017, 5:30 PM
madcatx added a comment.Jul 18 2017, 12:19 PM

The guideline suggests that a developer should not apply for a dev account if they do not intend to contribute over a longer period of time. As much as I'd like to help out as much as I can I'd prefer to not open a dev account to push these patches through.

Closed by commit R320:18e2236b492c: Display the error message in warning dialog (authored by madcatx, committed by elvisangelaccio). · Explain WhyJul 18 2017, 4:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmb/kio_smb_browse.cpp (6 lines)

Diff 16772

View Options

smb/kio_smb_browse.cpp

Loading...