Make error strings in a separate method
ClosedPublic
Actions

Authored by madcatx on Jul 16 2017, 1:22 PM.

Details

Reviewers

elvisangelaccio

Commits

R320:9307eb0fdc97: Make error strings in a separate method

Summary

Decouple the strings returned as error messages from the reportError() method.

Repository

R320 KIO Extras

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio added inline comments.

smb/kio_smb.h
97	You could use a `struct` since it defaults to `public` as visibility for members.

This revision is now accepted and ready to land.Jul 16 2017, 3:06 PM

I know, but I prefer to reserve the struct keyword for C-only code.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			smb/kio_smb.h (9 lines)
M			smb/kio_smb_browse.cpp (77 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	16771			Jul 16 2017, 1:16 PM	★	★
Diff 2	16877	7542649	R320:9307eb0fdc97782f8d7e8f598b7fe1b13da77f99	Jul 18 2017, 4:13 PM	★	★