Sometimes the DBus reply has no arguments, so avoid trying to access them.
Details
Details
- Reviewers
broulik davidedmundson - Group Reviewers
Plasma - Commits
- R856:a56dd8a1760c: Fix occasional abort in the krunner plugin
No crashes so far.
Diff Detail
Diff Detail
- Repository
- R856 Plasma Browser Integration
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
This shouldn't be needed.
Even an empty QList<QVariant> will have an argument of that empty QList<QVariant> and errors will have a different type.
It implies something is wrong elsewhere.
Comment Actions
I thought so too, until I got crashes without the test. IMO it can't hurt to prevent crashes due to misbehaviour of other components anyway.
Comment Actions
Can't really say if there's something wrong elsewhere, but FWIW this patch indeed fixes crashing krunner, see https://bugs.kde.org/show_bug.cgi?id=382521 for the backtrace.
Comment Actions
@davidedmundson Should we go with this now?
| tabsrunner/tabsrunner.cpp | ||
|---|---|---|
| 103 | Perhaps even check != 1 - it shouldn't have more than one argument either. | |