KUrlNavigator: expose the KUrlNavigatorButton that received a drop event
ClosedPublic

Authored by elvisangelaccio on Jul 13 2017, 4:02 PM.

Details

Summary

Commit 1e251d2f6a does not work with KUrlNavigator drops because the
drop event is processed at the KUrlNavigatorButton level. This means
that passing a KUrlNavigator to KJobWidgets::setWindow() results in a
wrong position for KIO::drop() menus (both on Wayland and X11).

To fix this issue, the DropJob needs to be associated to the
KUrlNavigatorButton that received the drop event. This class is
not exported, so we add a getter to KUrlNavigator that exposes
the relevant KUrlNavigatorButton as QWidget (which is enough because
the DropJob just needs to call mapToGlobal() on it).

Test Plan

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 13 2017, 4:02 PM
dfaure accepted this revision.Jul 27 2017, 6:20 AM
This revision is now accepted and ready to land.Jul 27 2017, 6:20 AM
This revision was automatically updated to reflect the committed changes.