The code wants to check whether we're not a tooltip. This didn't work when other flags,, such as WindowStaysOnTopHint were present.
Details
Details
- Reviewers
mart davidedmundson - Group Reviewers
Plasma - Commits
- R242:a19701c2529d: [Plasma Dialog] Fix flag conditions
My Alternatives popup now slides in from the panel. Verified that it follows the panel location (top/bottom)
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Your description doesn't match the code
This didn't work when other flags,, such as WindowStaysOnTopHint were present.
& Flag is the same as TestFlag()
From what I can tell, you've changed:
if (!tooltipFlag && !notification)
into if(! (tooltipFlag && !notification)
which is quite possibly correct and valid, but it doesn't match what you said.
Comment Actions
There's a bunch more q->flags & Qt::Tooltip, if we're going to change one, we should change them all.