Differential D6543

[KPageListViewDelegate] Pass widget to drawPrimitive
ClosedPublic
Actions

Authored by broulik on Jul 7 2017, 9:02 AM.

Details

Reviewers
kde-frameworks-devel
fvogt
Commits
R236:abe58c287c32: [KPageListViewDelegate] Pass widget to drawPrimitive in drawFocus
Summary

Ensure the style knows what widget its painting focus for.
Also take the widget's style (as is done in the delegate paint method)

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 7 2017, 9:02 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 7 2017, 9:02 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
fvogt accepted this revision.Jul 7 2017, 9:04 AM

Tested, works fine here.

I don't see any other cases of drawPrimitive being invoked without passing a widget.

This revision is now accepted and ready to land.Jul 7 2017, 9:04 AM
Closed by commit R236:abe58c287c32: [KPageListViewDelegate] Pass widget to drawPrimitive in drawFocus (authored by broulik). · Explain WhyJul 7 2017, 11:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kpageview_p.cpp (4 lines)

Diff 16301

View Options

src/kpageview_p.cpp

Loading...