Differential D6541

Emit signals from icon border when no mark was clicked
ClosedPublic
Actions

Authored by croick on Jul 7 2017, 7:16 AM.

Details

Reviewers
dhaumann
Group Reviewers
KTextEditor
Commits
R39:3b202d26f2ee: Emit signals from icon border when no mark was clicked
Summary
  • currently it is not possible to get a signal from the icon border menu when no mark is clicked, which prevents the creation of custom context menus for no marks
  • would probably break programs which set handled to true in any case without checking the mark type
Test Plan
  • tested the change with KDevelop and observed no change

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
croick created this revision.Jul 7 2017, 7:16 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 7 2017, 7:16 AM
Restricted Application added subscribers: Frameworks, kwrite-devel. · View Herald Transcript
dhaumann added a subscriber: dhaumann.Jul 10 2017, 4:29 PM

The patch looks good, but is there a concrete use-case?

croick added a comment.Jul 10 2017, 8:44 PM
In D6541#123758, @dhaumann wrote:

The patch looks good, but is there a concrete use-case?

I tried to implement a custom context menu for breakpoints and bookmarks in KDevelop, mainly for displaying the same icons which are used when right-clicking on an actual mark.
It's not super important I guess ;)

dhaumann accepted this revision.Jul 11 2017, 9:42 PM

I think the patch is fine.

This revision is now accepted and ready to land.Jul 11 2017, 9:42 PM
Closed by commit R39:3b202d26f2ee: Emit signals from icon border when no mark was clicked (authored by croick). · Explain WhyJul 12 2017, 8:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/document/katedocument.cpp (17 lines)

Diff 16605

View Options

src/document/katedocument.cpp

Loading...