Differential D6535

Use mutually exclusive group in Default Mark Type
ClosedPublic
Actions

Authored by kfunk on Jul 6 2017, 6:08 PM.

Details

Reviewers
cullmann
Commits
R39:98aec940ec0b: Use mutually exclusive group in Default Mark Type
Summary

Before:

Set Default Mark Type:

  • Bookmark
  • Breakpoint

After:

Set Default Mark Type:

( ) Bookmark
(x) Breakpoint

Follow-up on KDevelop patch: https://phabricator.kde.org/D6179

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.Jul 6 2017, 6:08 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 6 2017, 6:08 PM
Restricted Application added subscribers: Frameworks, kwrite-devel. · View Herald Transcript
kfunk updated this revision to Diff 16265.Jul 6 2017, 6:08 PM

Polish commit message

kfunk edited the summary of this revision. (Show Details)Jul 6 2017, 6:08 PM
croick added a subscriber: croick.Jul 7 2017, 7:03 AM
croick added inline comments.
src/view/kateviewhelpers.cpp
2254

this could be done once, after the if-else-block

kfunk updated this revision to Diff 16284.Jul 7 2017, 7:40 AM

Simplify code, address concerns

kfunk updated this revision to Diff 16285.Jul 7 2017, 7:43 AM

Fix logic. Sorry, must have been asleep here... :\

cullmann accepted this revision.Jul 9 2017, 11:17 AM
cullmann added a subscriber: cullmann.

Looks reasonable, feel free to commit it ;=)

This revision is now accepted and ready to land.Jul 9 2017, 11:17 AM
Closed by commit R39:98aec940ec0b: Use mutually exclusive group in Default Mark Type (authored by kfunk). · Explain WhyJul 9 2017, 11:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/view/kateviewhelpers.cpp (3 lines)

Diff 16417

View Options

src/view/kateviewhelpers.cpp

Loading...