Differential D6424

[Scripting] Throw a error from the Containment when the widget is not found
ClosedPublic
Actions

Authored by garg on Jun 28 2017, 7:09 PM.

Tags

Subscribers

davidedmundson, plasma-devel

Details

Reviewers

Group Reviewers

Commits

R120:94aa4152937f: [Scripting] Throw a error from the Containment when the widget is not found

Summary

Let's also move the applet pointer to right before it's used and
remove duplicated declarations.

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

garg created this revision.Jun 28 2017, 7:09 PM

Restricted Application added a project: Plasma. · View Herald TranscriptJun 28 2017, 7:09 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

garg added a reviewer: Plasma.Jun 28 2017, 7:10 PM

Mention the name of the widget too

In principle fine.

shell/scripting/containment.cpp
217–218	what about this one?
231	s/find/create

This revision now requires changes to proceed.Jun 28 2017, 8:43 PM

Update as per David's comments

Remove accidentally commited file

Remove useless debug

davidedmundson accepted this revision.Jun 28 2017, 8:59 PM

This revision is now accepted and ready to land.Jun 28 2017, 8:59 PM

Closed by commit R120:94aa4152937f: [Scripting] Throw a error from the Containment when the widget is not found (authored by garg). · Explain WhyJun 28 2017, 9:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			shell/scripting/containment.cpp (8 lines)

Diff 15971

shell/scripting/containment.cpp

Loading...