Differential D6424

[Scripting] Throw a error from the Containment when the widget is not found
ClosedPublic
Actions

Authored by garg on Jun 28 2017, 7:09 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:94aa4152937f: [Scripting] Throw a error from the Containment when the widget is not found
Summary

Let's also move the applet pointer to right before it's used and
remove duplicated declarations.

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
garg created this revision.Jun 28 2017, 7:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 28 2017, 7:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
garg added a reviewer: Plasma.Jun 28 2017, 7:10 PM
garg updated this revision to Diff 15962.Jun 28 2017, 7:31 PM

Mention the name of the widget too

davidedmundson requested changes to this revision.Jun 28 2017, 8:43 PM
davidedmundson added a subscriber: davidedmundson.

In principle fine.

shell/scripting/containment.cpp
217–218

what about this one?

231

s/find/create

This revision now requires changes to proceed.Jun 28 2017, 8:43 PM
garg updated this revision to Diff 15968.Jun 28 2017, 8:47 PM
garg edited edge metadata.

Update as per David's comments

garg updated this revision to Diff 15969.Jun 28 2017, 8:49 PM

Remove accidentally commited file

garg updated this revision to Diff 15970.Jun 28 2017, 8:50 PM

Remove useless debug

davidedmundson accepted this revision.Jun 28 2017, 8:59 PM
This revision is now accepted and ready to land.Jun 28 2017, 8:59 PM
Closed by commit R120:94aa4152937f: [Scripting] Throw a error from the Containment when the widget is not found (authored by garg). · Explain WhyJun 28 2017, 9:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/scripting/containment.cpp (8 lines)

Diff 15970

View Options

shell/scripting/containment.cpp

Loading...