[Places Panel] Disallow editing devices
ClosedPublic

Authored by broulik on Jun 20 2017, 10:04 AM.

Details

Summary

I introduced this bug when I changed the layout of the menu.
While it would be nice if one could edit devices, it is currently not possible and would require significant re-engineering effort in Solid. While the "Edit" menu works just fine, changes are not persisted.

Test Plan

No longer get an "Edit" entry in device context menus, consistent with open file dialog. "Edit" entry on other places still works

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 20 2017, 10:04 AM
Restricted Application added a subscriber: Konqueror. · View Herald TranscriptJun 20 2017, 10:04 AM

Not that I have ever used it, but, doesn't this remove the ability to change device icons or rename them in Dolphin?

Yes but you could never do that. If you do, next time Dolphin starts the change is undone. You also cannot from the Open dialog since they're not actual bookmarks but dynamically queried from Solid.

Yes but you could never do that. If you do, next time Dolphin starts the change is undone. You also cannot from the Open dialog since they're not actual bookmarks but dynamically queried from Solid.

Yep, you're right. Changes don't seem to persist.

This revision was automatically updated to reflect the committed changes.