Fix crash when trying to kill a finished NativeAppJob
ClosedPublic

Authored by croick on Jun 19 2017, 9:27 PM.

Details

Summary
  • when starting the same job twice, a dialog pops up, asking whether to kill the running job
  • if the job finished meanwhile, the running job instance ceases to exist and accessing its member causes a crash
  • probably the same as Bug 364317

Solution:

  • add a check for existence of the job after the dialog

BUG: 364317

Test Plan
  • start the same job twice (a unit test for instance)
  • click on "Yes" (do kill the running job), if the dialog pops up, after the job finished

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
croick created this revision.Jun 19 2017, 9:27 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJun 19 2017, 9:27 PM
apol accepted this revision.Jun 19 2017, 11:12 PM
apol added a subscriber: apol.

Thanks a lot!

This revision is now accepted and ready to land.Jun 19 2017, 11:12 PM
This revision was automatically updated to reflect the committed changes.